Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 970613002: Add //google_apis/* to 'gn check'. (Closed)

Created:
5 years, 9 months ago by tfarina
Modified:
5 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, zea+watch_chromium.org, Roger Tawa OOO till Jul 10th, Nicolas Zea
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add //google_apis/* to 'gn check'. This fixed the remaining erros found by 'gn check', so we can enable it on all bots. Checked with the following command lines: Linux $ gn gen out-gn $ gn check out-gn //google_apis/* $ Android $ gn gen out-gn-android --args='target_os="android"' $ gn check out-android //google_apis/* $ ChromeOS $ gn gen out-gn-chromeos --args='host_os="chromeos"' $ gn check out-gn-chromeos //google_apis/* BUG=None TEST=see above R=dpranke@chromium.org TBR=rogerta@chromium.org,zea@chromium.org CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Committed: https://crrev.com/9ee68196b71914e0231a5e3a6ac02db2a4f1d059 Cr-Commit-Position: refs/heads/master@{#318645}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M .gn View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M google_apis/gcm/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
tfarina
5 years, 9 months ago (2015-03-01 02:24:44 UTC) #1
Dirk Pranke
lgtm. Make sure you specify CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg in the CL description so that the CQ will ...
5 years, 9 months ago (2015-03-01 20:28:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/970613002/1
5 years, 9 months ago (2015-03-02 02:08:43 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-02 03:20:21 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 03:20:56 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ee68196b71914e0231a5e3a6ac02db2a4f1d059
Cr-Commit-Position: refs/heads/master@{#318645}

Powered by Google App Engine
This is Rietveld 408576698