Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Issue 970603003: Fix padding in home page settings. (Closed)

Created:
5 years, 9 months ago by newt (away)
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix padding in home page settings. The "on"/"off" text and the switch were both too close to the edge of the screen on pre-L devices. The bug arose because the LinearLayout had conflicting padding attributes: it defined "padding" inline, and used a style which defined "paddingStart" and "paddingEnd". The latter values were overriding the inline "padding" value. Committed: https://crrev.com/8ab5046b4a0f6eb8f3976b6693624d6371a042fb Cr-Commit-Position: refs/heads/master@{#319011}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/android/java/res/layout/homepage_preferences.xml View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
newt (away)
PTAL
5 years, 9 months ago (2015-03-04 02:46:35 UTC) #2
Kibeom Kim (inactive)
lgtm
5 years, 9 months ago (2015-03-04 02:47:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/970603003/1
5 years, 9 months ago (2015-03-04 02:49:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 03:11:31 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 03:12:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ab5046b4a0f6eb8f3976b6693624d6371a042fb
Cr-Commit-Position: refs/heads/master@{#319011}

Powered by Google App Engine
This is Rietveld 408576698