Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 970553002: Rearrange the Element interface to match the many specs (Closed)

Created:
5 years, 9 months ago by philipj_slow
Modified:
5 years, 9 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-dom_chromium.org, arv+blink, vivekg_samsung, sof, eae+blinkwatch, vivekg, dglazkov+blink, Inactive, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rearrange the Element interface to match the many specs https://dom.spec.whatwg.org/#interface-element and many other specs with partial Document interfaces. To make reviewing easier, this commit only changes the order of lines and adds comments. Actual spec sync will be done separately. The order of the generated code changes, but there are no actual changes. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191056

Patch Set 1 #

Patch Set 2 : oops wrong CSS spec #

Patch Set 3 : tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -70 lines) Patch
M Source/core/dom/Element.idl View 1 2 1 chunk +71 lines, -70 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
philipj_slow
PTAL. I think (hope) that Window should be the last big interface to rearrange.
5 years, 9 months ago (2015-02-28 16:59:32 UTC) #2
philipj_slow
oops wrong CSS spec
5 years, 9 months ago (2015-03-01 01:12:24 UTC) #3
philipj_slow
tweak
5 years, 9 months ago (2015-03-01 01:35:39 UTC) #4
haraken
LGTM
5 years, 9 months ago (2015-03-01 08:55:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/970553002/40001
5 years, 9 months ago (2015-03-01 15:26:25 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-01 16:45:04 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191056

Powered by Google App Engine
This is Rietveld 408576698