Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 970513004: Revert of Add a new enable_nonblocking_io field trial param for QUIC (Closed)

Created:
5 years, 9 months ago by qyearsley
Modified:
5 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, Alpha Left Google
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add a new enable_nonblocking_io field trial param for QUIC (patchset #6 id:120001 of https://codereview.chromium.org/938003003/) Reason for revert: Speculative revert to see whether this affects some tests that involve loading fonts in gfx_unittests (see failures at http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29). Original issue's description: > Add a new enable_nonblocking_io field trial param for QUIC which enables the new non-blocking IO support on windows. > > BUG=442392 > > Committed: https://crrev.com/83e8c1477cf5d41928b8c9035f0c4812828752f4 > Cr-Commit-Position: refs/heads/master@{#318555} TBR=rtenneti@chromium.org,rch@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=442392 Committed: https://crrev.com/369bca8b735e6275616052b9b9e3755f3305eb1f Cr-Commit-Position: refs/heads/master@{#318601}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -45 lines) Patch
M chrome/browser/io_thread.h View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/io_thread.cc View 3 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/io_thread_unittest.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M net/http/http_network_session.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/http/http_network_session.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M net/quic/quic_stream_factory.h View 2 chunks +0 lines, -4 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 4 chunks +0 lines, -10 lines 0 comments Download
M net/quic/quic_stream_factory_test.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
qyearsley
Created Revert of Add a new enable_nonblocking_io field trial param for QUIC
5 years, 9 months ago (2015-02-28 06:11:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/970513004/1
5 years, 9 months ago (2015-02-28 06:11:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-28 06:12:23 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/369bca8b735e6275616052b9b9e3755f3305eb1f Cr-Commit-Position: refs/heads/master@{#318601}
5 years, 9 months ago (2015-02-28 06:13:07 UTC) #4
qyearsley
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/968573002/ by qyearsley@chromium.org. ...
5 years, 9 months ago (2015-02-28 06:57:43 UTC) #5
ramant (doing other things)
5 years, 9 months ago (2015-03-01 02:00:40 UTC) #6
Message was sent while issue was closed.
lgtm

I doubt this CL is the reason.

Powered by Google App Engine
This is Rietveld 408576698