Issue 9705008: NaClDesc: Undo erroneous renaming of the DescWrapper methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9705008: NaClDesc: Undo erroneous renaming of the DescWrapper methods (Closed)

Created:
8 years, 9 months ago by Mark Seaborn

Modified:
8 years, 9 months ago

Reviewers:
bsy

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client

Visibility:
Public.

More Reviews

Description

NaClDesc: Undo erroneous renaming of the DescWrapper methods Renaming DescWrapper's SendMsg/RecvMsg to LowLevelSendMsg/LowLevelRecvMsg in r8015 was erroneous because they are the high-level variants that operate on NaClDescs, not NaClHandles. This should have been apparent given that the bodies of the methods were not changed in r8015! BUG=http://code.google.com/p/nativeclient/issues/detail?id=2627 TEST=compile Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=8028

Patch Set 1 #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -8 lines)			Patch
M	src/trusted/desc/nacl_desc_wrapper.h	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/trusted/desc/nacl_desc_wrapper.cc	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	src/trusted/nonnacl_util/sel_ldr_launcher.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages