Issue 970493003: Add support for pressure on pointer events

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 970493003: Add support for pressure on pointer events (Closed)

Created:
5 years, 9 months ago by eseidel

Modified:
5 years, 9 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add support for pressure on pointer events The touch demo needs some basic smoothing, right now it looks rather jittery after this change. But the pressure code is definitely working! R=abarth@chromium.org BUG= Committed: https://chromium.googlesource.com/external/mojo/+/82d6fa7b106c26b8c7087fca7c9d569695ab232f

Patch Set 1 #

Total comments: 2

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -5 lines)			Patch
M	sky/examples/touch-demo.sky	View	2 chunks	+10 lines, -5 lines	0 comments	Download
M	sky/shell/org/domokit/sky/shell/PlatformView.java	View	1 chunk	+8 lines, -0 lines	2 comments	Download
M	sky/shell/ui/input_event_converter.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

lgtm https://codereview.chromium.org/970493003/diff/1/sky/shell/org/domokit/sky/shell/PlatformView.java File sky/shell/org/domokit/sky/shell/PlatformView.java (right): https://codereview.chromium.org/970493003/diff/1/sky/shell/org/domokit/sky/shell/PlatformView.java#newcode127 sky/shell/org/domokit/sky/shell/PlatformView.java:127: So many blank lines. :) https://codereview.chromium.org/970493003/diff/1/sky/shell/org/domokit/sky/shell/PlatformView.java#newcode127 sky/shell/org/domokit/sky/shell/PlatformView.java:127: So ...

5 years, 9 months ago (2015-02-28 03:42:30 UTC) #2

eseidel

5 years, 9 months ago (2015-03-02 20:38:35 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
82d6fa7b106c26b8c7087fca7c9d569695ab232f (presubmit successful).

Expand Messages | Collapse Messages