Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Issue 970443002: Revert of Add remoting and PPAPI tests to GN build (Closed)

Created:
5 years, 9 months ago by eroman
Modified:
5 years, 9 months ago
Reviewers:
Dirk Pranke, brettw, kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add remoting and PPAPI tests to GN build (patchset #7 id:120001 of https://codereview.chromium.org/965633002/) Reason for revert: http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac%20GN&number=4498 ERROR at //remoting/host/BUILD.gn:56:7: Item not found "linux/x_server_clipboard.cc", ^---------------------------- You were trying to remove "linux/x_server_clipboard.cc" Original issue's description: > Add remoting and PPAPI tests to GN build > > BUG= > > Committed: https://crrev.com/d0437210926b14b1b7e06b2b56174fc92ade9c37 > Cr-Commit-Position: refs/heads/master@{#318539} TBR=kelvinp@chromium.org,dpranke@chromium.org,brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/d593eac9968cee2b5412ba22638ed16f0884c408 Cr-Commit-Position: refs/heads/master@{#318545}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -687 lines) Patch
M BUILD.gn View 3 chunks +2 lines, -4 lines 0 comments Download
D build/config/linux/gtk/BUILD.gn View 1 chunk +0 lines, -42 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/BUILD.gn View 3 chunks +17 lines, -2 lines 0 comments Download
M ppapi/BUILD.gn View 2 chunks +1 line, -75 lines 0 comments Download
M ppapi/ppapi_host.gypi View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/ppapi_tests.gypi View 4 chunks +0 lines, -4 lines 0 comments Download
D remoting/BUILD.gn View 1 chunk +0 lines, -104 lines 0 comments Download
M remoting/base/BUILD.gn View 2 chunks +9 lines, -40 lines 0 comments Download
M remoting/client/BUILD.gn View 1 chunk +11 lines, -35 lines 0 comments Download
M remoting/client/plugin/BUILD.gn View 2 chunks +7 lines, -14 lines 0 comments Download
D remoting/codec/BUILD.gn View 1 chunk +0 lines, -47 lines 0 comments Download
M remoting/host/BUILD.gn View 3 chunks +9 lines, -126 lines 0 comments Download
M remoting/host/it2me/BUILD.gn View 2 chunks +14 lines, -10 lines 0 comments Download
D remoting/host/native_messaging/BUILD.gn View 1 chunk +0 lines, -19 lines 0 comments Download
D remoting/host/setup/BUILD.gn View 1 chunk +0 lines, -32 lines 0 comments Download
M remoting/protocol/BUILD.gn View 3 chunks +7 lines, -68 lines 0 comments Download
M remoting/remoting.gyp View 2 chunks +1 line, -2 lines 0 comments Download
M remoting/remoting_host.gypi View 3 chunks +30 lines, -4 lines 0 comments Download
M remoting/remoting_host_srcs.gypi View 1 chunk +1 line, -35 lines 0 comments Download
M remoting/remoting_nacl.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D remoting/remoting_srcs.gni View 1 chunk +0 lines, -14 lines 0 comments Download
M remoting/remoting_srcs.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/remoting_test.gypi View 4 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
eroman
Created Revert of Add remoting and PPAPI tests to GN build
5 years, 9 months ago (2015-02-27 23:38:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/970443002/1
5 years, 9 months ago (2015-02-27 23:40:11 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-27 23:41:36 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-02-27 23:42:12 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d593eac9968cee2b5412ba22638ed16f0884c408
Cr-Commit-Position: refs/heads/master@{#318545}

Powered by Google App Engine
This is Rietveld 408576698