Change chrome android to use content_app_both

Change chrome android to use content_app_both

content_app_browser and content_app_child are designed to be used for Windows DLL, for android  we build browser and child process in same shared library, content_app_both should be used in Android.

BUG=464008
TBR=jochen

Committed: https://crrev.com/34a24da6b5dee735edecd2260253660fa9d56e97
Cr-Commit-Position: refs/heads/master@{#319147}

[michaelbai, 2015-03-04 03:36:23]

michaelbai@chromium.org changed reviewers:
+ jam@chromium.org

[gunsch, 2015-03-04 04:36:08]

gunsch@chromium.org changed reviewers:
+ gunsch@chromium.org

[gunsch, 2015-03-04 04:36:09]

drive-by comment, could you also:

git cl try -m tryserver.chromium.linux -b cast_shell -b cast_shell_apk

for good measure? (new trybots, not yet automatic)

https://codereview.chromium.org/970413002/diff/1/chromecast/chromecast.gyp
File chromecast/chromecast.gyp (right):

https://codereview.chromium.org/970413002/diff/1/chromecast/chromecast.gyp#ne...
chromecast/chromecast.gyp:177: '../content/content.gyp:content_app_both',
This target is also build by the Linux cast_shell, is that okay? It looks like
all the other targets touched in this changelist are Android-specific.

[michaelbai, 2015-03-04 04:41:37]

On 2015/03/04 04:36:09, gunsch wrote:
> drive-by comment, could you also:
> 
> git cl try -m tryserver.chromium.linux -b cast_shell -b cast_shell_apk
> 
> for good measure? (new trybots, not yet automatic)
> 
> https://codereview.chromium.org/970413002/diff/1/chromecast/chromecast.gyp
> File chromecast/chromecast.gyp (right):
> 
>
https://codereview.chromium.org/970413002/diff/1/chromecast/chromecast.gyp#ne...
> chromecast/chromecast.gyp:177: '../content/content.gyp:content_app_both',
> This target is also build by the Linux cast_shell, is that okay? It looks like
> all the other targets touched in this changelist are Android-specific.

Thanks, I were going to ping you tomorrow about which bots to run :)

[michaelbai, 2015-03-04 04:42:53]

jam@, would you like take a look? I want to confirm my understand is correct or
not.

[jam, 2015-03-04 07:08:26]

jam@chromium.org changed reviewers:
+ scottmg@chromium.org

[jam, 2015-03-04 07:08:27]

yes i believe that's correct, but adding scottmg to confirm. lgtm depending on
him.

[scottmg, 2015-03-04 18:06:00]

I don't really know what Android wants, but that seems fine based on the
description. You also need to update the BUILD.gn files similarly probably?

[michaelbai, 2015-03-04 19:02:24]

On 2015/03/04 18:06:00, scottmg wrote:
> I don't really know what Android wants, but that seems fine based on the
> description. You also need to update the BUILD.gn files similarly probably?

Thanks gn changed is added.

[scottmg, 2015-03-04 19:17:42]

lgtm

[michaelbai, 2015-03-04 20:06:36]

gunsch@ cast bots look good

[gunsch, 2015-03-04 21:00:15]

lgtm, thanks for running

[michaelbai, 2015-03-04 21:53:15]

The CQ bit was checked by michaelbai@chromium.org

[michaelbai, 2015-03-04 21:53:16]

The patchset sent to the CQ was uploaded after l-g-t-m from jam@chromium.org
Link to the patchset: https://codereview.chromium.org/970413002/#ps20001 (title:
"add gn")

[michaelbai, 2015-03-04 21:53:23]

The CQ bit was unchecked by michaelbai@chromium.org

[michaelbai, 2015-03-04 21:54:06]

TBR=jochen for BUILD.gn change

[michaelbai, 2015-03-04 21:54:17]

The CQ bit was checked by michaelbai@chromium.org

[commit-bot: I haz the power, 2015-03-04 21:54:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/970413002/20001

[commit-bot: I haz the power, 2015-03-04 22:44:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-04 22:45:30]

Patchset 2 (id:??) landed as
https://crrev.com/34a24da6b5dee735edecd2260253660fa9d56e97
Cr-Commit-Position: refs/heads/master@{#319147}