Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: testing/xvfb.py

Issue 9704099: Improve trace_inputs.py to output a format easy to convert to gypi. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix exception Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/isolate/isolate.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/xvfb.py
diff --git a/testing/xvfb.py b/testing/xvfb.py
index a5cb7aa9d15b38740b79065fc4068adda96ca43a..73bcd1682fa1175b8b7b29baa4108bda209e2446 100755
--- a/testing/xvfb.py
+++ b/testing/xvfb.py
@@ -64,8 +64,13 @@ def wait_for_xvfb(xdisplaycheck, env):
stdout=subprocess.PIPE,
stderr=subprocess.STDOUT,
env=env)
+ except OSError:
+ print >> sys.stderr, 'Failed to load %s with cwd=%s' % (
+ xdisplaycheck, os.getcwd())
+ return False
except subprocess.CalledProcessError:
- print >> sys.stderr, 'Xvfb failed to load properly.'
+ print >> sys.stderr, (
+ 'Xvfb failed to load properly while trying to run %s' % xdisplaycheck)
return False
return True
« no previous file with comments | « no previous file | tools/isolate/isolate.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698