Extensions: Don't pass the selected unpacked extension path from JS to C++

chrome/browser/ui/webui/extensions/extension_settings_handler.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_EXTENSIONS_EXTENSION_SETTINGS_HANDLER_H_
 #define CHROME_BROWSER_UI_WEBUI_EXTENSIONS_EXTENSION_SETTINGS_HANDLER_H_
 #pragma once
 
 #include <set>
 #include <string>
@@ skipping 51 matching lines @@
   // Extension Detail JSON Struct for page. (static for ease of testing).
   // Note: |service| and |warnings| can be NULL in unit tests.
   static base::DictionaryValue* CreateExtensionDetailValue(
       ExtensionService* service,
       const Extension* extension,
       const std::vector<ExtensionPage>& pages,
       const ExtensionWarningSet* warnings,
       bool enabled,
       bool terminated);
 
-  // ContentScript JSON Struct for page. (static for ease of testing).
-  static base::DictionaryValue* CreateContentScriptDetailValue(
-      const UserScript& script,
-      const FilePath& extension_path);
+  void GetLocalizedValues(base::DictionaryValue* localized_strings);
+
+ private:
+  // WebUIMessageHandler implementation.
+  virtual void RegisterMessages() OVERRIDE;
+
+  // SelectFileDialog::Listener implementation.
+  virtual void FileSelected(const FilePath& path,
+                            int index, void* params) OVERRIDE;
+  virtual void MultiFilesSelected(
+      const std::vector<FilePath>& files, void* params) OVERRIDE;
+  virtual void FileSelectionCanceled(void* params) OVERRIDE {}
+
+  // content::NotificationObserver implementation.
+  virtual void Observe(int type,
+                       const content::NotificationSource& source,
+                       const content::NotificationDetails& details) OVERRIDE;
+
+  // ExtensionUninstallDialog::Delegate implementation, used for receiving
+  // notification about uninstall confirmation dialog selections.
+  virtual void ExtensionUninstallAccepted() OVERRIDE;
+  virtual void ExtensionUninstallCanceled() OVERRIDE;
 
   // Callback for "requestExtensionsData" message.
   void HandleRequestExtensionsData(const base::ListValue* args);
 
   // Callback for "toggleDeveloperMode" message.
   void HandleToggleDeveloperMode(const base::ListValue* args);
 
   // Callback for "inspect" message.
   void HandleInspectMessage(const base::ListValue* args);
 
@@ skipping 11 matching lines @@
 
   // Callback for "uninstall" message.
   void HandleUninstallMessage(const base::ListValue* args);
 
   // Callback for "options" message.
   void HandleOptionsMessage(const base::ListValue* args);
 
   // Callback for "showButton" message.
   void HandleShowButtonMessage(const base::ListValue* args);
 
-  // Callback for "load" message.
-  void HandleLoadMessage(const base::ListValue* args);
-
-  // Callback for "pack" message.
-  void HandlePackMessage(const base::ListValue* args);
-
   // Callback for "autoupdate" message.
   void HandleAutoUpdateMessage(const base::ListValue* args);
 
-  // Utility for calling javascript window.alert in the page.
+  // Callback for "loadUnpackedExtension" message.
+  void HandleLoadUnpackedExtensionMessage(const base::ListValue* args);
+
+  // Utility for calling JavaScript window.alert in the page.
   void ShowAlert(const std::string& message);
 
-  // Callback for "selectFilePath" message.
-  void HandleSelectFilePathMessage(const base::ListValue* args);
-
   // Utility for callbacks that get an extension ID as the sole argument.
   const Extension* GetExtension(const base::ListValue* args);
 
   // Forces a UI update if appropriate after a notification is received.
   void MaybeUpdateAfterNotification();
 
   // Register for notifications that we need to reload the page.
   void MaybeRegisterForNotifications();
 
-  // SelectFileDialog::Listener
-  virtual void FileSelected(const FilePath& path,
-                            int index, void* params) OVERRIDE;
-  virtual void MultiFilesSelected(
-      const std::vector<FilePath>& files, void* params) OVERRIDE;
-  virtual void FileSelectionCanceled(void* params) OVERRIDE {}
-
-  // WebUIMessageHandler implementation.
-  virtual void RegisterMessages() OVERRIDE;
-
-  void GetLocalizedValues(base::DictionaryValue* localized_strings);
-
-  // content::NotificationObserver implementation.
-  virtual void Observe(int type,
-                       const content::NotificationSource& source,
-                       const content::NotificationDetails& details) OVERRIDE;
-
-  // ExtensionUninstallDialog::Delegate implementation, used for receiving
-  // notification about uninstall confirmation dialog selections.
-  virtual void ExtensionUninstallAccepted() OVERRIDE;
-  virtual void ExtensionUninstallCanceled() OVERRIDE;
-
- private:
   // Helper that lists the current active html pages for an extension.
   std::vector<ExtensionPage> GetActivePagesForExtension(
       const Extension* extension);
   void GetActivePagesForExtensionProcess(
       const std::set<content::RenderViewHost*>& views,
       std::vector<ExtensionPage> *result);
 
   // Returns the ExtensionUninstallDialog object for this class, creating it if
   // needed.
   ExtensionUninstallDialog* GetExtensionUninstallDialog();
@@ skipping 16 matching lines @@
   bool ignore_notifications_;
 
   // The page may be refreshed in response to a RENDER_VIEW_HOST_DELETED,
   // but the iteration over RenderViewHosts will include the host because the
   // notification is sent when it is in the process of being deleted (and before
   // it is removed from the process). Keep a pointer to it so we can exclude
   // it from the active views.
   content::RenderViewHost* deleting_rvh_;
 
   // We want to register for notifications only after we've responded at least
-  // once to the page, otherwise we'd be calling javacsript functions on objects
+  // once to the page, otherwise we'd be calling JavaScript functions on objects
   // that don't exist yet when notifications come in. This variable makes sure
   // we do so only once.
   bool registered_for_notifications_;
 
   content::NotificationRegistrar registrar_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionSettingsHandler);
 };
 
 #endif  // CHROME_BROWSER_UI_WEBUI_EXTENSIONS_EXTENSION_SETTINGS_HANDLER_H_