Extensions: Don't pass the selected unpacked extension path from JS to C++

chrome/browser/resources/extensions/pack_extension_overlay.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('extensions', function() {
   /**
    * PackExtensionOverlay class
    * Encapsulated handling of the 'Pack Extension' overlay page.
    * @constructor
    */
@@ skipping 33 matching lines @@
      * Handles a click on the pack button.
      * @param {Event} e The click event.
      */
     handleCommit_: function(e) {
       var extensionPath = $('extensionRootDir').value;
       var privateKeyPath = $('extensionPrivateKey').value;
       chrome.send('pack', [extensionPath, privateKeyPath, 0]);
     },
 
     /**
-    * Utility function which asks the C++ to show a platform-specific file
-    * select dialog, and fire |callback| with the |filePath| that resulted.
-    * |selectType| can be either 'file' or 'folder'. |operation| can be 'load',
-    * 'packRoot', or 'pem' which are signals to the C++ to do some
-    * operation-specific configuration.
-    * @private
-    */
+     * Utility function which asks the C++ to show a platform-specific file
+     * select dialog, and fire |callback| with the |filePath| that resulted.
+     * |selectType| can be either 'file' or 'folder'. |operation| can be 'load'
+     * or 'pem' which are signals to the C++ to do some operation-specific
+     * configuration.
+     * @private
+     */
     showFileDialog_: function(selectType, operation, callback) {
       handleFilePathSelected = function(filePath) {
         callback(filePath);
         handleFilePathSelected = function() {};
       };
 
-      chrome.send('extensionSettingsSelectFilePath', [selectType, operation]);
+      chrome.send('packExtensionSelectFilePath', [selectType, operation]);
     },
 
     /**
      * Handles the showing of the extension directory browser.
      * @param {Event} e Change event.
      * @private
      */
     handleBrowseExtensionDir_: function(e) {
       this.showFileDialog_('folder', 'load', function(filePath) {
         $('extensionRootDir').value = filePath;
       });
     },
 
     /**
      * Handles the showing of the extension private key file.
      * @param {Event} e Change event.
      * @private
      */
     handleBrowsePrivateKey_: function(e) {
-      this.showFileDialog_('file', 'load', function(filePath) {
+      this.showFileDialog_('file', 'pem', function(filePath) {
         $('extensionPrivateKey').value = filePath;
       });
     },
   };
 
   /**
    * Wrap up the pack process by showing the success |message| and closing
    * the overlay.
    * @param {String} message The message to show to the user.
    */
@@ skipping 28 matching lines @@
   };
 
   // Export
   return {
     PackExtensionOverlay: PackExtensionOverlay
   };
 });
 
 // Update the C++ call so this isn't necessary.
 var PackExtensionOverlay = extensions.PackExtensionOverlay;