Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 970253002: [turbofan] Fix exception being re-thrown after finally-block. (Closed)

Created:
5 years, 9 months ago by Michael Starzinger
Modified:
5 years, 9 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix exception being re-thrown after finally-block. This makes sure that the implicit exception edges in the graph pass the correct exception object and also fixes a bug in the dominance relationship of the value entering the finally block and it's uses. R=jarin@chromium.org TEST=cctest/test-run-jsexceptions/FinallyBreak Committed: https://crrev.com/064be2385ad395c2b4e877322e8ba47efa7ec97e Cr-Commit-Position: refs/heads/master@{#26989}

Patch Set 1 #

Patch Set 2 : Fix comment. #

Patch Set 3 : Correct exception. #

Patch Set 4 : Sneak in alpha sorting. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -18 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 2 9 chunks +27 lines, -10 lines 0 comments Download
M src/compiler/control-builders.h View 1 1 chunk +8 lines, -3 lines 0 comments Download
M src/compiler/control-builders.cc View 1 chunk +8 lines, -4 lines 0 comments Download
M src/compiler/linkage.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 9 months ago (2015-03-03 18:09:51 UTC) #1
Jarin
lgtm
5 years, 9 months ago (2015-03-04 13:54:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/970253002/60001
5 years, 9 months ago (2015-03-04 14:13:06 UTC) #4
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-04 14:28:37 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 14:28:53 UTC) #6
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/064be2385ad395c2b4e877322e8ba47efa7ec97e
Cr-Commit-Position: refs/heads/master@{#26989}

Powered by Google App Engine
This is Rietveld 408576698