Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 970243003: Refactoring chrome JNI registration. (Closed)

Created:
5 years, 9 months ago by michaelbai
Modified:
5 years, 9 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactoring chrome JNI registration. Move the JNI registration to OnJNIOnLoadRegisterJNI. Remove ChromeMainDelegateAndroid::RegisterApplicationNativeMethods() TBR=jochen BUG=447393 Committed: https://crrev.com/3994cb32fb8d7db1951c1c0412d1f4e496b0a093 Cr-Commit-Position: refs/heads/master@{#319129}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -53 lines) Patch
M chrome/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
A chrome/android/shell/chrome_shell_entry_point.cc View 1 chunk +29 lines, -0 lines 0 comments Download
M chrome/android/sync_shell/chrome_main_delegate_chrome_sync_shell_android.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/android/sync_shell/chrome_main_delegate_chrome_sync_shell_android.cc View 1 chunk +12 lines, -7 lines 0 comments Download
A chrome/app/android/chrome_jni_onload.h View 1 chunk +22 lines, -0 lines 0 comments Download
M chrome/app/android/chrome_jni_onload.cc View 1 chunk +24 lines, -11 lines 0 comments Download
M chrome/app/android/chrome_main_delegate_android.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/app/android/chrome_main_delegate_android.cc View 3 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_android.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_shell.gypi View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/test/base/chrome_test_suite.cc View 2 chunks +0 lines, -18 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
michaelbai
David overall nyquist@ chrome/android/sync_shell jay chrome/test
5 years, 9 months ago (2015-03-03 19:09:49 UTC) #2
David Trainor- moved to gerrit
lgtm
5 years, 9 months ago (2015-03-03 19:37:15 UTC) #3
Jay Civelli
LGTM for chrome/test
5 years, 9 months ago (2015-03-04 18:09:40 UTC) #4
nyquist
chrome/android/sync_shell lgtm
5 years, 9 months ago (2015-03-04 19:05:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/970243003/1
5 years, 9 months ago (2015-03-04 19:14:52 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/47275)
5 years, 9 months ago (2015-03-04 19:37:22 UTC) #9
michaelbai
On 2015/03/04 19:37:22, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
5 years, 9 months ago (2015-03-04 19:41:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/970243003/1
5 years, 9 months ago (2015-03-04 19:42:58 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-04 21:20:57 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-04 21:22:29 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3994cb32fb8d7db1951c1c0412d1f4e496b0a093
Cr-Commit-Position: refs/heads/master@{#319129}

Powered by Google App Engine
This is Rietveld 408576698