Issue 970213002: [History] Set |deleteCompleteCallback_| before calling -removeVisits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 970213002: [History] Set |deleteCompleteCallback_| before calling -removeVisits. (Closed)

Created:
5 years, 9 months ago by justincohen

Modified:
5 years, 9 months ago

Reviewers:
Dan Beam

CC:
chromium-reviews, Patrick Dubroy, pam+watch_chromium.org, arv+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[History] Set |deleteCompleteCallback_| before calling -removeVisits. Speculative fix for unit tests failure -- sometimes calling -removeVisits will call back into history.js with -deleteComplete before |deleteCompleteCallback_| has been set. BUG=452893 Committed: https://crrev.com/83973417b121076cd51555819887b27164f3f7e7 Cr-Commit-Position: refs/heads/master@{#318906}

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/resources/history/history.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Dan Beam

lgtm but I don't really think this'll fix your problem...

5 years, 9 months ago (2015-03-03 16:34:32 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/970213002/1

5 years, 9 months ago (2015-03-03 16:37:18 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-03 18:05:39 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/83973417b121076cd51555819887b27164f3f7e7
Cr-Commit-Position: refs/heads/master@{#318906}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages