Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 9702068: Move extension pop-ups and notifications to the new auto-resize code. (Closed)

Created:
8 years, 9 months ago by levin
Modified:
8 years, 8 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org
Visibility:
Public.

Description

Move extension pop-ups and notifications to the new auto-resize code. This should fix the "flicker" issues where autosize ends up flipping back and forth between two size in rapid succession. The change in render_widget_host is needed to avoid cases where the OnMsgUpdateRect happens while processing a resize message which may result in recursion back into the resize code which is undesirable. BUG=58816, 56693 TEST=Try out auto resize in notifications and extensions. Best to do with windows that change size and hit the maximum as well as minimum sizes on the 3 desktop platforms for pop-ups. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127824

Patch Set 1 #

Patch Set 2 : build fixes #

Patch Set 3 : build fixes #

Patch Set 4 : typo fix #

Patch Set 5 : updates #

Patch Set 6 : synced #

Patch Set 7 : small update #

Total comments: 1

Patch Set 8 : added comment as suggested in reviews. #

Patch Set 9 : v1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
levin
John, please look at the balloon changes in here. This change is all about moving ...
8 years, 9 months ago (2012-03-15 19:30:11 UTC) #1
Aaron Boodman
+finnur Finnur, can you please look at this from an extensions point of view?
8 years, 9 months ago (2012-03-15 19:32:07 UTC) #2
johnnyg
LGTM Notification balloon stuff looks good. Sorry, can't figure out how to become johnnyg@chromium.org.
8 years, 9 months ago (2012-03-15 19:52:04 UTC) #3
Finnur
My Mac and GTK foo is not very strong but those changes look simple and ...
8 years, 9 months ago (2012-03-16 13:31:02 UTC) #4
levin
Adding more folks (from owners files)... sesek would you look over the chrome/browser/ui/cocoa changes? sky ...
8 years, 9 months ago (2012-03-20 16:01:23 UTC) #5
sky
LGTM http://codereview.chromium.org/9702068/diff/8004/content/browser/renderer_host/render_widget_host_impl.cc File content/browser/renderer_host/render_widget_host_impl.cc (right): http://codereview.chromium.org/9702068/diff/8004/content/browser/renderer_host/render_widget_host_impl.cc#newcode1189 content/browser/renderer_host/render_widget_host_impl.cc:1189: bool post_callback = new_auto_size_.IsEmpty(); Add a comment as ...
8 years, 9 months ago (2012-03-20 16:15:06 UTC) #6
Evan Stade
gtk lgtm
8 years, 9 months ago (2012-03-20 17:50:09 UTC) #7
Robert Sesek
cocoa lgtm
8 years, 9 months ago (2012-03-20 18:17:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/levin@chromium.org/9702068/18001
8 years, 9 months ago (2012-03-20 21:20:17 UTC) #9
commit-bot: I haz the power
8 years, 9 months ago (2012-03-20 23:07:08 UTC) #10
Change committed as 127824

Powered by Google App Engine
This is Rietveld 408576698