Issue 970203005: Simplify TextTrackCue::isActive

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 970203005: Simplify TextTrackCue::isActive (Closed)

Created:
5 years, 9 months ago by fs

Modified:
5 years, 9 months ago

Reviewers:
philipj_slow

CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, blink-reviews-html_chromium.org, dglazkov+blink, vcarbune.chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Simplify TextTrackCue::isActive Make it a simple getter for the m_isActive flag. The other aspects of the current condition should be managed by TextTrack. A breakdown on the (non-assert) usage follows. MediaControlTextTrackContainerElement::updateDisplay Already explicitly checks TextTrackCue::track() and isRendered on the track. TextTrackCueList::collectActiveCues Caller (TextTrack::activeCues) checks mode != 'disabled'. CueTimeline::* (mostly updateActiveCues) This class manages the flag, and should be notified when a cue is removed or a track has it's mode changed to disabled. BUG=321654 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191298

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -6 lines)			Patch
M	Source/core/html/track/CueTimeline.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/html/track/TextTrackCue.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/track/TextTrackCue.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/970203005/1

5 years, 9 months ago (2015-03-04 16:55:25 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-04 17:28:32 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191298

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages