Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Issue 970163002: Pepper: Add PPB_IsolatedFileSystem_Private;0.2 to histograms.xml. (Closed)

Created:
5 years, 9 months ago by bbudge
Modified:
5 years, 9 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, dmichael (off chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pepper: Add PPB_IsolatedFileSystem_Private;0.2 to histograms.xml. This API was missed in the CL to add missing APIs to histograms. https://codereview.chromium.org/938283004/ This change also tweaks a comment that caused pretty_print.py to complain. BUG= Committed: https://crrev.com/f88cefd779c2bf39b0e33c6c00e67eca949c343a Cr-Commit-Position: refs/heads/master@{#318886}

Patch Set 1 #

Patch Set 2 : Fix stray comment to quiet pretty printer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M tools/metrics/histograms/histograms.xml View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bbudge
5 years, 9 months ago (2015-03-03 12:31:07 UTC) #2
Alexei Svitkine (slow)
lgtm
5 years, 9 months ago (2015-03-03 14:28:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/970163002/20001
5 years, 9 months ago (2015-03-03 14:30:18 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-03 16:33:18 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 16:34:36 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f88cefd779c2bf39b0e33c6c00e67eca949c343a
Cr-Commit-Position: refs/heads/master@{#318886}

Powered by Google App Engine
This is Rietveld 408576698