[Input View] Makes the input view window support window.resizeTo() and w3c visibility API its web c…

ui/keyboard/keyboard_controller_proxy.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_KEYBOARD_KEYBOARD_CONTROLLER_PROXY_H_
 #define UI_KEYBOARD_KEYBOARD_CONTROLLER_PROXY_H_
 
 #include "base/memory/scoped_ptr.h"
 #include "content/public/common/media_stream_request.h"
 #include "ui/base/ime/text_input_type.h"
@@ skipping 47 matching lines @@
   // Hides the container window of the keyboard. The default implementation
   // simply hides the container. An overridden implementation can set up
   // necesasry animation, or delay the visibility change as it desires.
   virtual void HideKeyboardContainer(aura::Window* container);
 
   // Updates the type of the focused text input box. The default implementation
   // calls OnTextInputBoxFocused javascript function through webui to update the
   // type the of focused input box.
   virtual void SetUpdateInputType(ui::TextInputType type);
 
+  // The current keyboard content window's height in logical pixels.
+  static int keyboard_height;

[kevers, 2013/12/03 00:08:12]

Please avoid using public static data members.  KeyboardLayoutManager already
has access to the KeyboardController and thus indirect access to the
ControllerProxy.

In addition, I don't think we should be caching persistent information in a
proxy.  

[Shu Chen, 2013/12/03 01:54:42]

Done.

+
+  // Whether the current keyboard window is resizing. This is used in keyboard
+  // contents delegate's MoveContents().
+  static bool keyboard_resizing_from_contents;
+
  protected:
   // Gets the BrowserContext to use for creating the WebContents hosting the
   // keyboard.
   virtual content::BrowserContext* GetBrowserContext() = 0;
 
   // The implementation can choose to setup the WebContents before the virtual
   // keyboard page is loaded (e.g. install a WebContentsObserver).
   // SetupWebContents() is called right after creating the WebContents, before
   // loading the keyboard page.
   virtual void SetupWebContents(content::WebContents* contents);
 
  private:
   // Reloads the web contents to the valid url from GetValidUrl().
   void ReloadContents();
 
   // Gets the valid url from default url or override url.
   const GURL& GetValidUrl();
 
   const GURL default_url_;
   GURL override_url_;
 
   scoped_ptr<content::WebContents> keyboard_contents_;
 
   DISALLOW_COPY_AND_ASSIGN(KeyboardControllerProxy);
 };
 
 }  // namespace keyboard
 
 #endif  // UI_KEYBOARD_KEYBOARD_CONTROLLER_PROXY_H_