Chromium Code Reviews
Help | Chromium Project | Sign in
(384)

Issue 9701108: Don't filter shortcut keys when a tab is opened in app ("windowed") mode. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 1 month ago by garykac
Modified:
2 years, 1 month ago
Reviewers:
Peter Kasting, Wez
CC:
chromium-reviews_chromium.org, Dmitry Lomov (chromium), jennb, Dmitry Titov, jianli, dcheng, Andrei
Visibility:
Public.

Description

Don't filter shortcut keys when a tab is opened in app mode (aka: windowed or pop-up mode).

Currently, certain browser shortcut keys (ctrl-w/n/t) are not sent to the page. This is done to avoid issues with loading the page and waiting for a response before being able to handle the important shortcuts.

This change removes that filtering *iff* the page is app mode (right-click and "Open as Window" from the "New Tab" page).

BUG=84332
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127787

Patch Set 1 #

Patch Set 2 : Trigger on apps #

Patch Set 3 : Comment #

Patch Set 4 : Update comment #

Patch Set 5 : Remove fullscreen trigger #

Patch Set 6 : Remove blank line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Lint Patch
M chrome/browser/ui/browser.cc View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments ? errors Download
Commit:

Messages

Total messages: 9
garykac
Peter, please take a look at this. It passes all keys to a tab if ...
2 years, 1 month ago #1
garykac
+wez
2 years, 1 month ago #2
Peter Kasting
I disagree that fullscreen mode should automatically result in the page getting all keys. I ...
2 years, 1 month ago #3
garykac
On 2012/03/19 21:48:05, Peter Kasting wrote: > I disagree that fullscreen mode should automatically result ...
2 years, 1 month ago #4
Peter Kasting
LGTM
2 years, 1 month ago #5
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/garykac@chromium.org/9701108/9001
2 years, 1 month ago #6
I haz the power (commit-bot)
Try job failure for 9701108-9001 (retry) on mac_rel for step "compile" (clobber build). It's a ...
2 years, 1 month ago #7
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/garykac@chromium.org/9701108/9001
2 years, 1 month ago #8
I haz the power (commit-bot)
2 years, 1 month ago #9
Change committed as 127787
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6