Don't filter shortcut keys when a tab is opened in app ("windowed") mode.

Don't filter shortcut keys when a tab is opened in app mode (aka: windowed or pop-up mode).

Currently, certain browser shortcut keys (ctrl-w/n/t) are not sent to the page. This is done to avoid issues with loading the page and waiting for a response before being able to handle the important shortcuts.

This change removes that filtering *iff* the page is app mode (right-click and "Open as Window" from the "New Tab" page).

BUG=84332
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127787

[garykac, 2012-03-19 20:39:47]

Peter, please take a look at this.

It passes all keys to a tab if it was launched in "windowed mode". This
windowed/popup mode is the current stand-in for our Apps v2 container.

Darin suggested we should make this change for fullscreen as well as
windowed/app mode. So I've included that as well.

Thanks.

[garykac, 2012-03-19 20:41:37]

+wez

[Peter Kasting, 2012-03-19 21:48:05]

I disagree that fullscreen mode should automatically result in the page getting
all keys.  I think the page should have to register its desire via some API call
in order to get these.  Being an app is sufficient proxy for that, going
fullscreen is not.

[garykac, 2012-03-20 02:32:03]

On 2012/03/19 21:48:05, Peter Kasting wrote:
> I disagree that fullscreen mode should automatically result in the page
getting
> all keys.  I think the page should have to register its desire via some API
call
> in order to get these.  Being an app is sufficient proxy for that, going
> fullscreen is not.

I remove the fullscreen trigger. It now only applies to windowed mode.

[Peter Kasting, 2012-03-20 02:37:53]

LGTM

[commit-bot: I haz the power, 2012-03-20 17:48:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/garykac@chromium.org/9701108/9001

[commit-bot: I haz the power, 2012-03-20 18:42:24]

Try job failure for 9701108-9001 (retry) on mac_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-03-20 18:44:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/garykac@chromium.org/9701108/9001

[commit-bot: I haz the power, 2012-03-20 21:22:13]

Change committed as 127787