Files.app: Cancel all selections on ESC key.

Files.app: Cancel all selections on ESC key.

BUG=459462
TEST=check that ESC cancels selections on list/grid view, and that pressing ESC while renaming doesn't cancel selection.

Committed: https://crrev.com/a1c4c0ce53abca1d3c44201aa82f7c01e7c3fd53
Cr-Commit-Position: refs/heads/master@{#318856}

[fukino, 2015-03-03 08:06:31]

fukino@chromium.org changed reviewers:
+ yawano@chromium.org

[fukino, 2015-03-03 08:06:31]

Could you take a look? Thanks!

[yawano, 2015-03-03 08:12:15]

lgtm with very small nit.

https://codereview.chromium.org/970103002/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/ui/file_table.js (right):

https://codereview.chromium.org/970103002/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/ui/file_table.js:1131: if (e.keyCode
== 27 && !e.ctrlKey && !e.shiftKey) {
very small nit: Use === instead of ==.

[fukino, 2015-03-03 08:17:53]

Thank you!

https://codereview.chromium.org/970103002/diff/1/ui/file_manager/file_manager...
File ui/file_manager/file_manager/foreground/js/ui/file_table.js (right):

https://codereview.chromium.org/970103002/diff/1/ui/file_manager/file_manager...
ui/file_manager/file_manager/foreground/js/ui/file_table.js:1131: if (e.keyCode
== 27 && !e.ctrlKey && !e.shiftKey) {
On 2015/03/03 08:12:15, yawano wrote:
> very small nit: Use === instead of ==.

Done.

[fukino, 2015-03-03 08:17:58]

The CQ bit was checked by fukino@chromium.org

[fukino, 2015-03-03 08:17:58]

The patchset sent to the CQ was uploaded after l-g-t-m from yawano@chromium.org
Link to the patchset: https://codereview.chromium.org/970103002/#ps20001 (title:
"Use === to compare numbers.")

[commit-bot: I haz the power, 2015-03-03 08:18:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/970103002/20001

[commit-bot: I haz the power, 2015-03-03 09:02:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-03 09:02:53]

Patchset 2 (id:??) landed as
https://crrev.com/a1c4c0ce53abca1d3c44201aa82f7c01e7c3fd53
Cr-Commit-Position: refs/heads/master@{#318856}