Added C++ wrappers for PPB_HostResolver_Private interface.

Added C++ wrappers for PPB_HostResolver_Private interface.

BUG=114225
TEST=*HostResolverPrivate


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=127929

[ygorshenin1, 2012-03-15 16:13:43]

+ Dmitry

[yzshen1, 2012-03-16 17:38:01]

http://codereview.chromium.org/9701024/diff/2002/ppapi/cpp/private/host_resol...
File ppapi/cpp/private/host_resolver_private.cc (right):

http://codereview.chromium.org/9701024/diff/2002/ppapi/cpp/private/host_resol...
ppapi/cpp/private/host_resolver_private.cc:20: template <> const char*
interface_name<PPB_HostResolver_Private>() {
Wez is working on explicitly specifying version number in the cpp wrappers. I
think we should follow that.
For example, https://chromiumcodereview.appspot.com/9699106/

http://codereview.chromium.org/9701024/diff/2002/ppapi/cpp/private/host_resol...
File ppapi/cpp/private/host_resolver_private.h (right):

http://codereview.chromium.org/9701024/diff/2002/ppapi/cpp/private/host_resol...
ppapi/cpp/private/host_resolver_private.h:32: void GetCanonicalName(std::string*
canonical_name);
How about returning a std::string?

[yzshen1, 2012-03-16 17:38:02]

http://codereview.chromium.org/9701024/diff/2002/ppapi/cpp/private/host_resol...
File ppapi/cpp/private/host_resolver_private.cc (right):

http://codereview.chromium.org/9701024/diff/2002/ppapi/cpp/private/host_resol...
ppapi/cpp/private/host_resolver_private.cc:20: template <> const char*
interface_name<PPB_HostResolver_Private>() {
Wez is working on explicitly specifying version number in the cpp wrappers. I
think we should follow that.
For example, https://chromiumcodereview.appspot.com/9699106/

http://codereview.chromium.org/9701024/diff/2002/ppapi/cpp/private/host_resol...
File ppapi/cpp/private/host_resolver_private.h (right):

http://codereview.chromium.org/9701024/diff/2002/ppapi/cpp/private/host_resol...
ppapi/cpp/private/host_resolver_private.h:32: void GetCanonicalName(std::string*
canonical_name);
How about returning a std::string?

[brettw, 2012-03-16 19:32:20]

http://codereview.chromium.org/9701024/diff/2002/ppapi/cpp/private/host_resol...
File ppapi/cpp/private/host_resolver_private.h (right):

http://codereview.chromium.org/9701024/diff/2002/ppapi/cpp/private/host_resol...
ppapi/cpp/private/host_resolver_private.h:32: void GetCanonicalName(std::string*
canonical_name);
Actually, we should return a pp::Var and PASS_REF what the C layer returns into
it. We don't want the C++ layer doing this type of conversions.

[ygorshenin1, 2012-03-19 08:41:56]

PTAL.

http://codereview.chromium.org/9701024/diff/2002/ppapi/cpp/private/host_resol...
File ppapi/cpp/private/host_resolver_private.cc (right):

http://codereview.chromium.org/9701024/diff/2002/ppapi/cpp/private/host_resol...
ppapi/cpp/private/host_resolver_private.cc:20: template <> const char*
interface_name<PPB_HostResolver_Private>() {
On 2012/03/16 17:38:02, yzshen1 wrote:
> Wez is working on explicitly specifying version number in the cpp wrappers. I
> think we should follow that.
> For example, https://chromiumcodereview.appspot.com/9699106/

Done.

http://codereview.chromium.org/9701024/diff/2002/ppapi/cpp/private/host_resol...
File ppapi/cpp/private/host_resolver_private.h (right):

http://codereview.chromium.org/9701024/diff/2002/ppapi/cpp/private/host_resol...
ppapi/cpp/private/host_resolver_private.h:32: void GetCanonicalName(std::string*
canonical_name);
On 2012/03/16 19:32:21, brettw wrote:
> Actually, we should return a pp::Var and PASS_REF what the C layer returns
into
> it. We don't want the C++ layer doing this type of conversions.

Done.

[brettw, 2012-03-19 16:00:58]

lgtm

http://codereview.chromium.org/9701024/diff/11002/ppapi/cpp/private/host_reso...
File ppapi/cpp/private/host_resolver_private.cc (right):

http://codereview.chromium.org/9701024/diff/11002/ppapi/cpp/private/host_reso...
ppapi/cpp/private/host_resolver_private.cc:59: return pp::Var(pp::PassRef(),
pp_canonical_name);
I normally do PASS_REF here. PassRef is an enum and and you're calling the
default constructor on it (PASS_REF is the enum value). Although it works in
this case, it seems a bit weird.

Also, you can remove all the pp:: in this function.

[ygorshenin1, 2012-03-20 07:40:56]

Thanks!

http://codereview.chromium.org/9701024/diff/11002/ppapi/cpp/private/host_reso...
File ppapi/cpp/private/host_resolver_private.cc (right):

http://codereview.chromium.org/9701024/diff/11002/ppapi/cpp/private/host_reso...
ppapi/cpp/private/host_resolver_private.cc:59: return pp::Var(pp::PassRef(),
pp_canonical_name);
On 2012/03/19 16:00:58, brettw wrote:
> I normally do PASS_REF here. PassRef is an enum and and you're calling the
> default constructor on it (PASS_REF is the enum value). Although it works in
> this case, it seems a bit weird.
> 
> Also, you can remove all the pp:: in this function.

Done.

[yzshen1, 2012-03-20 17:14:09]

lgtm

[commit-bot: I haz the power, 2012-03-21 07:47:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ygorshenin@chromium.org/9701024/23001

[commit-bot: I haz the power, 2012-03-21 10:08:40]

Change committed as 127929