Issue 9701: Port a resource fetcher test shell test to linux.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9701: Port a resource fetcher test shell test to linux. (Closed)

Created:
12 years, 1 month ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
tony, agl

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Port a resource fetcher test shell test to linux. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=5034

Patch Set 3 : '' #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -11 lines)			Patch
	M	webkit/glue/resource_fetcher_unittest.cc	View	1 2	5 chunks	+39 lines, -10 lines	0 comments	Download
	M	webkit/tools/test_shell/SConscript	View		2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

This unit test used ::SetTimer/::KillTimer. I used gtk timer functions as linux equivalents.

12 years, 1 month ago (2008-11-07 20:56:28 UTC) #1

Evan Stade

the 'a' in the title shouldn't be there (this actually ports all ResourceFetcherTests)

12 years, 1 month ago (2008-11-07 21:05:04 UTC) #2

agl

http://codereview.chromium.org/9701/diff/203/4 File webkit/glue/resource_fetcher_unittest.cc (right): http://codereview.chromium.org/9701/diff/203/4#newcode93 Line 93: continue_timing_ = false; I'm confused why you don't ...

12 years, 1 month ago (2008-11-07 21:28:42 UTC) #3

Evan Stade

12 years, 1 month ago (2008-11-07 21:47:48 UTC) #4

LGTM

Expand Messages | Collapse Messages

Issue 9701: Port a resource fetcher test shell test to linux. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Messages