Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 970043002: Remove chrome.principals API (Closed)

Created:
5 years, 9 months ago by Ryan Sleevi
Modified:
5 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove chrome.principals API It was never implemented or used; a replacement for the principalsPrivate extension API. It's been untouched for over a year. BUG=463335 Committed: https://crrev.com/511c501ba80de0a1dd08f8a31701083b90fb4af8 Cr-Commit-Position: refs/heads/master@{#320777}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Bad merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -249 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
D chrome/browser/signin/principals_message_filter.h View 1 chunk +0 lines, -36 lines 0 comments Download
D chrome/browser/signin/principals_message_filter.cc View 1 chunk +0 lines, -48 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_renderer.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download
D chrome/renderer/principals_extension_bindings.h View 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/renderer/principals_extension_bindings.cc View 1 chunk +0 lines, -128 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Ryan Sleevi
Roger: Death to dead code. If we can remove principalsPrivate as well (which crbug.com/298164 suggests ...
5 years, 9 months ago (2015-03-03 01:35:05 UTC) #2
Roger Tawa OOO till Jul 10th
lgtm OK to remove this code for now. We still need a way to expose ...
5 years, 9 months ago (2015-03-10 13:55:16 UTC) #3
Ryan Sleevi
thestig@chromium.org: Please review changes in chrome/renderer
5 years, 9 months ago (2015-03-10 17:05:43 UTC) #5
Lei Zhang
lgtm
5 years, 9 months ago (2015-03-10 19:27:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/970043002/1
5 years, 9 months ago (2015-03-10 19:31:56 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/4020) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 9 months ago (2015-03-10 19:35:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/970043002/40001
5 years, 9 months ago (2015-03-16 19:04:27 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-16 19:47:12 UTC) #14
commit-bot: I haz the power
5 years, 9 months ago (2015-03-16 19:47:42 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/511c501ba80de0a1dd08f8a31701083b90fb4af8
Cr-Commit-Position: refs/heads/master@{#320777}

Powered by Google App Engine
This is Rietveld 408576698