Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 970023002: Moved gpu factories to media/renderers/ (Closed)

Created:
5 years, 9 months ago by servolk
Modified:
5 years, 9 months ago
Reviewers:
xhwang, jam, DaleCurtis, jamesr
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, posciak+watch_chromium.org, nasko+codewatch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moved gpu factories to media/renderers/ Since DefaultRendererFactory uses GPU factories, code that instantiates the default factory need to include GPU factories headers and need to be able to instantiate them as well, so moving the GPU factories (both the mock and the real one) to media/renderers/ to make deps easier. BUG=457959 Committed: https://crrev.com/8b3b39bc38e111503353d5c5afa37b4b9d091d2e Cr-Commit-Position: refs/heads/master@{#318922}

Patch Set 1 #

Patch Set 2 : Updated include in pepper_video_encoder_host.cc #

Patch Set 3 : Fixed mojo webmediaplayer_factory.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -211 lines) Patch
M content/public/renderer/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M content/public/renderer/video_encode_accelerator.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/renderer_gpu_video_accelerator_factories.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/rtc_video_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/rtc_video_decoder_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/rtc_video_decoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/rtc_video_encoder.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/rtc_video_encoder_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc/peer_connection_dependency_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_video_encoder_host.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_thread_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M media/BUILD.gn View 1 3 chunks +4 lines, -4 lines 0 comments Download
D media/filters/gpu_video_accelerator_factories.h View 1 chunk +0 lines, -78 lines 0 comments Download
D media/filters/gpu_video_accelerator_factories.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M media/filters/gpu_video_decoder.cc View 1 chunk +1 line, -1 line 0 comments Download
D media/filters/mock_gpu_video_accelerator_factories.h View 1 chunk +0 lines, -61 lines 0 comments Download
D media/filters/mock_gpu_video_accelerator_factories.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M media/media.gyp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M media/renderers/default_renderer_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
A + media/renderers/gpu_video_accelerator_factories.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + media/renderers/gpu_video_accelerator_factories.cc View 1 chunk +1 line, -1 line 0 comments Download
A + media/renderers/mock_gpu_video_accelerator_factories.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + media/renderers/mock_gpu_video_accelerator_factories.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/html_viewer/webmediaplayer_factory.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (7 generated)
servolk
5 years, 9 months ago (2015-03-03 01:19:53 UTC) #2
DaleCurtis
You definitely don't need all these OWNERS, please pare it down to only those required. ...
5 years, 9 months ago (2015-03-03 01:24:12 UTC) #3
servolk
On 2015/03/03 01:24:12, DaleCurtis wrote: > You definitely don't need all these OWNERS, please pare ...
5 years, 9 months ago (2015-03-03 01:29:28 UTC) #4
DaleCurtis
You only need a single content/ and media/ OWNER; though in this case I'd like ...
5 years, 9 months ago (2015-03-03 01:33:38 UTC) #5
DaleCurtis
(If there's only per-file OWNERS in a given file, just walk up to the next ...
5 years, 9 months ago (2015-03-03 01:34:33 UTC) #6
servolk
On 2015/03/03 01:34:33, DaleCurtis wrote: > (If there's only per-file OWNERS in a given file, ...
5 years, 9 months ago (2015-03-03 02:09:06 UTC) #10
jam
lgtm
5 years, 9 months ago (2015-03-03 04:33:05 UTC) #11
xhwang
lgtm
5 years, 9 months ago (2015-03-03 17:21:46 UTC) #12
servolk
On 2015/03/03 17:21:46, xhwang wrote: > lgtm +jamesr@, could you please take super quick look ...
5 years, 9 months ago (2015-03-03 17:52:58 UTC) #14
jamesr
lgtm
5 years, 9 months ago (2015-03-03 19:02:34 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/970023002/40001
5 years, 9 months ago (2015-03-03 19:04:22 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-03 19:08:34 UTC) #19
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 19:09:07 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8b3b39bc38e111503353d5c5afa37b4b9d091d2e
Cr-Commit-Position: refs/heads/master@{#318922}

Powered by Google App Engine
This is Rietveld 408576698