Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 9700023: Move creation of content TabContentsViews to content so that we can hide these headers through DEPS… (Closed)

Created:
8 years, 9 months ago by jam
Modified:
8 years, 9 months ago
Reviewers:
Avi (use Gerrit), Jói
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Move creation of content TabContentsViews to content so that we can hide these headers through DEPS and avoid any more includes until TabContentsViewsViews is removed. I also moved all the TCVXDelegate to be in one header, that way we can more conveniently ask the embedder for a delegate without a lot of ifdefs. BUG=98716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126730

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : fix mac #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -946 lines) Patch
M chrome/browser/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 4 chunks +24 lines, -29 lines 0 comments Download
A + chrome/browser/tab_contents/chrome_web_contents_view_delegate_gtk.h View 1 2 2 chunks +20 lines, -18 lines 0 comments Download
A + chrome/browser/tab_contents/chrome_web_contents_view_delegate_gtk.cc View 1 6 chunks +30 lines, -30 lines 0 comments Download
A + chrome/browser/tab_contents/chrome_web_contents_view_delegate_mac.h View 1 2 3 4 chunks +14 lines, -14 lines 0 comments Download
A + chrome/browser/tab_contents/chrome_web_contents_view_delegate_mac.mm View 3 chunks +13 lines, -12 lines 0 comments Download
A + chrome/browser/tab_contents/chrome_web_contents_view_delegate_win.h View 3 chunks +10 lines, -10 lines 0 comments Download
A + chrome/browser/tab_contents/chrome_web_contents_view_delegate_win.cc View 9 chunks +13 lines, -13 lines 0 comments Download
D chrome/browser/tab_contents/chrome_web_contents_view_gtk_delegate.h View 1 chunk +0 lines, -68 lines 0 comments Download
D chrome/browser/tab_contents/chrome_web_contents_view_gtk_delegate.cc View 1 chunk +0 lines, -157 lines 0 comments Download
D chrome/browser/tab_contents/chrome_web_contents_view_mac_delegate.h View 1 chunk +0 lines, -66 lines 0 comments Download
D chrome/browser/tab_contents/chrome_web_contents_view_mac_delegate.mm View 1 chunk +0 lines, -68 lines 0 comments Download
D chrome/browser/tab_contents/chrome_web_contents_view_win_delegate.h View 1 chunk +0 lines, -65 lines 0 comments Download
D chrome/browser/tab_contents/chrome_web_contents_view_win_delegate.cc View 1 chunk +0 lines, -162 lines 0 comments Download
M chrome/browser/ui/gtk/constrained_window_gtk.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/constrained_window_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 4 chunks +8 lines, -20 lines 0 comments Download
M content/browser/mock_content_browser_client.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/mock_content_browser_client.cc View 1 chunk +6 lines, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 1 3 chunks +27 lines, -4 lines 0 comments Download
M content/browser/tab_contents/tab_contents_view_gtk.h View 1 3 chunks +4 lines, -7 lines 0 comments Download
M content/browser/tab_contents/tab_contents_view_gtk.cc View 5 chunks +4 lines, -9 lines 0 comments Download
M content/browser/tab_contents/tab_contents_view_win.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/tab_contents/tab_contents_view_win.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/tab_contents/web_contents_view_mac.h View 5 chunks +6 lines, -6 lines 0 comments Download
M content/browser/tab_contents/web_contents_view_mac.mm View 3 chunks +5 lines, -4 lines 0 comments Download
M content/content_browser.gypi View 2 chunks +1 line, -9 lines 0 comments Download
M content/public/browser/content_browser_client.h View 2 chunks +10 lines, -1 line 2 comments Download
A + content/public/browser/web_contents_view_delegate.h View 2 chunks +48 lines, -5 lines 0 comments Download
D content/public/browser/web_contents_view_gtk_delegate.h View 1 chunk +0 lines, -57 lines 0 comments Download
D content/public/browser/web_contents_view_mac_delegate.h View 1 chunk +0 lines, -44 lines 0 comments Download
D content/public/browser/web_contents_view_win_delegate.h View 1 chunk +0 lines, -43 lines 0 comments Download
M content/shell/shell_content_browser_client.h View 1 chunk +3 lines, -1 line 0 comments Download
M content/shell/shell_content_browser_client.cc View 1 chunk +5 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jam
I'll remove the tab_contents_view_gtk.h include in a followup change, I need to make the delegate ...
8 years, 9 months ago (2012-03-14 16:59:33 UTC) #1
jam
->Avi
8 years, 9 months ago (2012-03-14 19:53:21 UTC) #2
Avi (use Gerrit)
A small note about clarifying ownership semantics, but it lgtm. http://codereview.chromium.org/9700023/diff/8001/content/public/browser/content_browser_client.h File content/public/browser/content_browser_client.h (right): http://codereview.chromium.org/9700023/diff/8001/content/public/browser/content_browser_client.h#newcode105 ...
8 years, 9 months ago (2012-03-14 20:48:24 UTC) #3
jam
http://codereview.chromium.org/9700023/diff/8001/content/public/browser/content_browser_client.h File content/public/browser/content_browser_client.h (right): http://codereview.chromium.org/9700023/diff/8001/content/public/browser/content_browser_client.h#newcode105 content/public/browser/content_browser_client.h:105: // embedder to return an (optional) delegate to customize ...
8 years, 9 months ago (2012-03-14 20:59:26 UTC) #4
Jói
8 years, 9 months ago (2012-03-15 12:41:00 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698