Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 969913002: Fix rate, pitch, and volume from web speech synthesis API to extensions. (Closed)

Created:
5 years, 9 months ago by dmazzoni
Modified:
5 years, 9 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix rate, pitch, and volume from web speech synthesis API to extensions. The web speech synthesis API was correctly passing through an utterance's rate, pitch, and volume to native TTS, but not to extension-based speech. This fixes the bug, and I filed another bug to clean up the redundancy that led to this bug being there. BUG=376280 Committed: https://crrev.com/e2db68ee5c607f2f63208d50679343ec27814f8d Cr-Commit-Position: refs/heads/master@{#320946}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Remove logging #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M chrome/browser/speech/extension_api/tts_engine_extension_api.cc View 1 2 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dmazzoni
5 years, 9 months ago (2015-03-02 22:44:43 UTC) #2
David Tseng
lgtm b https://codereview.chromium.org/969913002/diff/1/chrome/browser/speech/extension_api/tts_engine_extension_api.cc File chrome/browser/speech/extension_api/tts_engine_extension_api.cc (right): https://codereview.chromium.org/969913002/diff/1/chrome/browser/speech/extension_api/tts_engine_extension_api.cc#newcode141 chrome/browser/speech/extension_api/tts_engine_extension_api.cc:141: LOG(ERROR) << "TtsExtensionEngine::Speak"; Remove https://codereview.chromium.org/969913002/diff/1/chrome/browser/speech/extension_api/tts_engine_extension_api.cc#newcode145 chrome/browser/speech/extension_api/tts_engine_extension_api.cc:145: LOG(ERROR) ...
5 years, 9 months ago (2015-03-16 17:56:51 UTC) #3
dmazzoni
Removed logging, thanks.
5 years, 9 months ago (2015-03-17 17:33:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/969913002/20001
5 years, 9 months ago (2015-03-17 17:33:35 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-17 18:32:03 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 18:32:59 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e2db68ee5c607f2f63208d50679343ec27814f8d
Cr-Commit-Position: refs/heads/master@{#320946}

Powered by Google App Engine
This is Rietveld 408576698