Address NewApi Android lint warnings in src/media.

Address NewApi Android lint warnings in src/media.

Android lint complains when we use APIs added to Android after ICS
because these will causes crashes if used on ICS devices. In cases where
we only call the API on later versions of Android, we need to annotate
the method or class with @TargetApi to tell Android lint that each
particular use of the new API is safe. This adds a bunch of such
@TargetApi annotations.

BUG=266140
Committed: https://crrev.com/3a06d2fbbe2c3e2ccabdb3858002435700edbef1
Cr-Commit-Position: refs/heads/master@{#319703}

[newt (away), 2015-03-02 23:05:09]

newt@chromium.org changed reviewers:
+ henrika@chromium.org, mcasas@chromium.org, qinmin@chromium.org,
rtoy@chromium.org, xhwang@chromium.org

[newt (away), 2015-03-02 23:05:10]

PTAL

I've added several TODOs where I'd like to update the code (before landing this
CL) based on your feedback.

qinmin: MediaCodecBridge.java and everything else for OWNERS approval
henrika: AudioManagerAndroid.java
xhwang: MediaDrmBridge.java
mcasas: VideoCaptureCamera.java and VideoCaptureCamera2.java
rtoy: WebAudioMediaCodecBridge.java

[Raymond Toy, 2015-03-02 23:16:46]

https://codereview.chromium.org/969883002/diff/20001/media/base/android/java/...
File
media/base/android/java/src/org/chromium/media/WebAudioMediaCodecBridge.java
(right):

https://codereview.chromium.org/969883002/diff/20001/media/base/android/java/...
media/base/android/java/src/org/chromium/media/WebAudioMediaCodecBridge.java:24:
//TODO: is this class only used on JELLY_BEAN and above?
Yes.  WebAudio requires the MediaCodec class that only exists on JellyBean and
later.  There is a check for this in content/child/runtime_features.cc so this
code is never run unless we're on JellyBean.

[xhwang, 2015-03-03 01:25:56]

https://codereview.chromium.org/969883002/diff/20001/media/base/android/java/...
File media/base/android/java/src/org/chromium/media/MediaDrmBridge.java (right):

https://codereview.chromium.org/969883002/diff/20001/media/base/android/java/...
media/base/android/java/src/org/chromium/media/MediaDrmBridge.java:38:
@TargetApi(Build.VERSION_CODES.JELLY_BEAN_MR2)
Sorry, our case is a bit tricky... See:

https://code.google.com/p/chromium/codesearch#chromium/src/media/base/android...

In summary, this class should only be used on 4.4.1 and above.

[henrika (OOO until Aug 14), 2015-03-03 08:29:19]

LGTM.

[henrika (OOO until Aug 14), 2015-03-03 08:43:33]

Adding comment to AudioManagerAndroid.java manually here (not able to post my
draft):

(Draft) 2015/03/03 08:31:51
Nice catch. I think we are saved by the fact that a typical calling sequence is 

if (isAudioLowLatencySupported())
  getAudioLowLatencyOutputFrameSize()..

and AFIK, only recent devices supports low-latency output.

However, it would be great if you could add a check here and return 
DEFAULT_FRAME_PER_BUFFER for SDK < 17. Thanks!
Edit

[henrika (OOO until Aug 14), 2015-03-03 08:44:23]

My comment is for line 508.

[newt (away), 2015-03-06 00:26:02]

https://codereview.chromium.org/969883002/diff/20001/media/base/android/java/...
File media/base/android/java/src/org/chromium/media/MediaDrmBridge.java (right):

https://codereview.chromium.org/969883002/diff/20001/media/base/android/java/...
media/base/android/java/src/org/chromium/media/MediaDrmBridge.java:38:
@TargetApi(Build.VERSION_CODES.JELLY_BEAN_MR2)
On 2015/03/03 01:25:56, xhwang wrote:
> Sorry, our case is a bit tricky... See:
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/media/base/android...
> 
> In summary, this class should only be used on 4.4.1 and above.

Thanks. Updated this to KITKAT.

https://codereview.chromium.org/969883002/diff/20001/media/base/android/java/...
File
media/base/android/java/src/org/chromium/media/WebAudioMediaCodecBridge.java
(right):

https://codereview.chromium.org/969883002/diff/20001/media/base/android/java/...
media/base/android/java/src/org/chromium/media/WebAudioMediaCodecBridge.java:24:
//TODO: is this class only used on JELLY_BEAN and above?
On 2015/03/02 23:16:46, Raymond Toy wrote:
> Yes.  WebAudio requires the MediaCodec class that only exists on JellyBean and
> later.  There is a check for this in content/child/runtime_features.cc so this
> code is never run unless we're on JellyBean.

Noted. Thanks.

[newt (away), 2015-03-06 00:26:15]

On 2015/03/03 08:43:33, henrika wrote:
> Adding comment to AudioManagerAndroid.java manually here (not able to post my
> draft):
> 
> (Draft) 2015/03/03 08:31:51
> Nice catch. I think we are saved by the fact that a typical calling sequence
is 
> 
> if (isAudioLowLatencySupported())
>   getAudioLowLatencyOutputFrameSize()..
> 
> and AFIK, only recent devices supports low-latency output.
> 
> However, it would be great if you could add a check here and return 
> DEFAULT_FRAME_PER_BUFFER for SDK < 17. Thanks!
> Edit

Done.

[newt (away), 2015-03-06 00:26:43]

PTAL

[newt (away), 2015-03-06 00:26:59]

qinmin and mcasas: friendly ping

[xhwang, 2015-03-06 00:49:22]

https://codereview.chromium.org/969883002/diff/40001/media/base/android/java/...
File media/base/android/java/src/org/chromium/media/MediaDrmBridge.java (right):

https://codereview.chromium.org/969883002/diff/40001/media/base/android/java/...
media/base/android/java/src/org/chromium/media/MediaDrmBridge.java:37:
@TargetApi(Build.VERSION_CODES.KITKAT)
I don't know how this works, but we need 4.4.1 and KITKAT includes 4.4.0. Does
this matter?

[newt (away), 2015-03-06 01:05:41]

https://codereview.chromium.org/969883002/diff/40001/media/base/android/java/...
File media/base/android/java/src/org/chromium/media/MediaDrmBridge.java (right):

https://codereview.chromium.org/969883002/diff/40001/media/base/android/java/...
media/base/android/java/src/org/chromium/media/MediaDrmBridge.java:37:
@TargetApi(Build.VERSION_CODES.KITKAT)
On 2015/03/06 00:49:22, xhwang wrote:
> I don't know how this works, but we need 4.4.1 and KITKAT includes 4.4.0. Does
> this matter?

It doesn't matter in this case.

Android lint provides helpful error messages in cases where we accidentally call
APIs that don't exist on earlier Android versions and @TargetApi is the way of
suppressing those warnings if they're false positives.

@TargetApi indicates that this class either 1) is only intended to be used on
the given API level or higher (this is the case for MediaDrmBridge), or 2) this
class is used on earlier API versions, but it won't call methods that don't
exist in those API levels. MediaDrmBridge isn't used before 4.4.1 (and thus
isn't used before 4.4.0), so this annotation is correct (though it would be more
accurate if there were a separate API level for 4.4.1 vs 4.4.0).

[xhwang, 2015-03-06 01:12:47]

On 2015/03/06 01:05:41, newt wrote:
>
https://codereview.chromium.org/969883002/diff/40001/media/base/android/java/...
> File media/base/android/java/src/org/chromium/media/MediaDrmBridge.java
(right):
> 
>
https://codereview.chromium.org/969883002/diff/40001/media/base/android/java/...
> media/base/android/java/src/org/chromium/media/MediaDrmBridge.java:37:
> @TargetApi(Build.VERSION_CODES.KITKAT)
> On 2015/03/06 00:49:22, xhwang wrote:
> > I don't know how this works, but we need 4.4.1 and KITKAT includes 4.4.0.
Does
> > this matter?
> 
> It doesn't matter in this case.
> 
> Android lint provides helpful error messages in cases where we accidentally
call
> APIs that don't exist on earlier Android versions and @TargetApi is the way of
> suppressing those warnings if they're false positives.
> 
> @TargetApi indicates that this class either 1) is only intended to be used on
> the given API level or higher (this is the case for MediaDrmBridge), or 2)
this
> class is used on earlier API versions, but it won't call methods that don't
> exist in those API levels. MediaDrmBridge isn't used before 4.4.1 (and thus
> isn't used before 4.4.0), so this annotation is correct (though it would be
more
> accurate if there were a separate API level for 4.4.1 vs 4.4.0).

Thanks for the explanation! MediaDrmBrdige.java lgtm

[mcasas, 2015-03-06 02:13:37]

VideoCaptureCamera* LGTM.

[Raymond Toy, 2015-03-06 16:56:24]

lgtm for WebAudioMediaCodecBridge.java, in case you need one.

[qinmin, 2015-03-06 18:11:05]

lgtm

[newt (away), 2015-03-06 18:14:33]

qinmin: could you respond to the questions I added in MediaCodecBridge.java?
They're all marked with TODOs, which I'd like to resolve before landing this CL.

[qinmin, 2015-03-06 18:20:11]

https://codereview.chromium.org/969883002/diff/40001/media/base/android/java/...
File media/base/android/java/src/org/chromium/media/MediaCodecBridge.java
(right):

https://codereview.chromium.org/969883002/diff/40001/media/base/android/java/...
media/base/android/java/src/org/chromium/media/MediaCodecBridge.java:34: //TODO:
is this class only used on JELLY_BEAN and above?
MediaCodec is available after Api 16(JB), so this class won't be available for
ICS at all.

https://codereview.chromium.org/969883002/diff/40001/media/base/android/java/...
media/base/android/java/src/org/chromium/media/MediaCodecBridge.java:504: //
TODO: is setVideoBitrate() or requestKeyFrameSoon() called on pre-KK devices?
No, it shouldn't

[newt (away), 2015-03-07 01:06:41]

The CQ bit was checked by newt@chromium.org

[newt (away), 2015-03-07 01:06:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
henrika@chromium.org, mcasas@chromium.org, qinmin@chromium.org,
xhwang@chromium.org, rtoy@chromium.org
Link to the patchset: https://codereview.chromium.org/969883002/#ps60001 (title:
"qinmin's comments")

[commit-bot: I haz the power, 2015-03-07 01:08:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/969883002/60001

[commit-bot: I haz the power, 2015-03-07 03:09:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-07 03:09:09]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build
URL)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
Timed out jobs are not retried to avoid causing additional load on the builders
with large pending queues.

[newt (away), 2015-03-09 18:21:21]

The CQ bit was checked by newt@chromium.org

[newt (away), 2015-03-09 18:21:22]

The patchset sent to the CQ was uploaded after l-g-t-m from mcasas@chromium.org,
qinmin@chromium.org, xhwang@chromium.org, henrika@chromium.org,
rtoy@chromium.org
Link to the patchset: https://codereview.chromium.org/969883002/#ps80001 (title:
"rebase")

[commit-bot: I haz the power, 2015-03-09 18:22:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/969883002/80001

[commit-bot: I haz the power, 2015-03-09 19:13:47]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-03-09 19:14:34]

Patchset 5 (id:??) landed as
https://crrev.com/3a06d2fbbe2c3e2ccabdb3858002435700edbef1
Cr-Commit-Position: refs/heads/master@{#319703}