Issue 969863002: Images don't appear when they finish loading

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 969863002: Images don't appear when they finish loading (Closed)

Created:
5 years, 9 months ago by abarth-chromium

Modified:
5 years, 9 months ago

Reviewers:
ojan

CC:
esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Images don't appear when they finish loading RenderImage needs to notify its base class unconditionally so that it will schedule a visual update. This broke in https://codereview.chromium.org/791023006. R=ojan@chromium.org BUG=https://github.com/domokit/mojo/issues/55 Committed: https://chromium.googlesource.com/external/mojo/+/42e5e06b0657ef7261a4a061e2471b5626f42f4e

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	sky/engine/core/rendering/RenderImage.cpp	View		1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

5 years, 9 months ago (2015-03-02 21:03:40 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
42e5e06b0657ef7261a4a061e2471b5626f42f4e (presubmit successful).