Two small bugfixes

1. Token CRCs are not handled correctly. This adds the corrected Whispernet binary (from cl/87383487), and a test to confirm the correct behavior.

2. If we get tokens that require more than one padding character, the padding will not be completely removed when appropriate. This is a simple change in the js.

BUG=463218
Committed: https://crrev.com/6e37f17aa09f5244315d6eb84fa305154bc65062
Cr-Commit-Position: refs/heads/master@{#319015}

[Charlie, 2015-03-02 23:01:03]

Patchset #1 (id:1) has been deleted

[Charlie, 2015-03-03 17:52:54]

ckehoe@chromium.org changed reviewers:
+ rkc@chromium.org

[rkc, 2015-03-03 20:49:42]

lgtm % comment

https://codereview.chromium.org/969843002/diff/20001/chrome/browser/copresenc...
File chrome/browser/copresence/chrome_whispernet_client_browsertest.cc (right):

https://codereview.chromium.org/969843002/diff/20001/chrome/browser/copresenc...
chrome/browser/copresence/chrome_whispernet_client_browsertest.cc:286:
IN_PROC_BROWSER_TEST_F(ChromeWhispernetClientTest, MAYBE_CRC) {
MAYBE_Crc
We use the first upper, rest lower format for abbreviations. Granted this is not
always followed, but IIRC, this is the style suggestion.

[Charlie, 2015-03-04 00:58:28]

The CQ bit was checked by ckehoe@chromium.org

[Charlie, 2015-03-04 00:58:28]

The patchset sent to the CQ was uploaded after l-g-t-m from rkc@chromium.org
Link to the patchset: https://codereview.chromium.org/969843002/#ps60001 (title:
"Fixing test name")

[Charlie, 2015-03-04 00:58:36]

https://codereview.chromium.org/969843002/diff/20001/chrome/browser/copresenc...
File chrome/browser/copresence/chrome_whispernet_client_browsertest.cc (right):

https://codereview.chromium.org/969843002/diff/20001/chrome/browser/copresenc...
chrome/browser/copresence/chrome_whispernet_client_browsertest.cc:286:
IN_PROC_BROWSER_TEST_F(ChromeWhispernetClientTest, MAYBE_CRC) {
On 2015/03/03 20:49:42, Rahul Chaturvedi wrote:
> MAYBE_Crc
> We use the first upper, rest lower format for abbreviations. Granted this is
not
> always followed, but IIRC, this is the style suggestion.

Done.

[commit-bot: I haz the power, 2015-03-04 00:59:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/969843002/60001

[commit-bot: I haz the power, 2015-03-04 03:23:01]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-03-04 03:24:05]

Patchset 3 (id:??) landed as
https://crrev.com/6e37f17aa09f5244315d6eb84fa305154bc65062
Cr-Commit-Position: refs/heads/master@{#319015}

[Finnur, 2015-03-04 08:35:17]

A revert of this CL (patchset #3 id:60001) has been created in
https://codereview.chromium.org/979723002/ by finnur@chromium.org.

The reason for reverting is: Causes test to consistently time out.
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%2...

[ RUN      ] ChromeWhispernetClientTest.EncodeAndDecode
[724:3320:0303/204246:WARNING:data_reduction_proxy_config.cc(240)] SPDY proxy
OFF at startup
[3956:4296:0303/204248:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[724:4156:0303/204249:INFO:CONSOLE(5)] "Not allowed to load local resource:
chrome://resources/css/text_defaults.css", source:
chrome-extension://bpfmnplchembfbdgieamdodgaencleal/background.html (5)
[724:4156:0303/204249:INFO:CONSOLE(83)] "init: Starting Nacl bridge.", source:
chrome-extension://bpfmnplchembfbdgieamdodgaencleal/js/init.js (83)
[2012:2524:0303/204249:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[2012:2832:0303/204249:ERROR:pnacl_translation_resource_host.cc(135)] Got
invalid platformfilefortransit
[724:4156:0303/204253:INFO:CONSOLE(65)] "init: Nacl ready!", source:
chrome-extension://bpfmnplchembfbdgieamdodgaencleal/js/init.js (65)
[724:4156:0303/204254:INFO:CONSOLE(26)] "Configuring encoder and decoder for
client E77A9C58-00C9-4A99-AC57-1353FB0B918D", source:
chrome-extension://bpfmnplchembfbdgieamdodgaencleal/js/init.js (26)
[223/223] ChromeWhispernetClientTest.EncodeAndDecode (TIMED OUT)
.