Glue layer settings for OffscreenPreRaster.

Glue layer settings for OffscreenPreRaster.

BUG=460638
Committed: https://crrev.com/0d149cf3d79089c25fbe69bbee6c187fe88358a2
Cr-Commit-Position: refs/heads/master@{#318758}

[hush (inactive), 2015-03-02 19:15:02]

Patchset #1 (id:1) has been deleted

[hush (inactive), 2015-03-02 19:15:27]

hush@chromium.org changed reviewers:
+ boliu@chromium.org

[hush (inactive), 2015-03-02 19:15:27]

PTAL!

[boliu, 2015-03-02 19:17:17]

lgtm % nits

https://codereview.chromium.org/969833002/diff/20001/android_webview/glue/jav...
File
android_webview/glue/java/src/com/android/webview/chromium/ContentSettingsAdapter.java
(right):

https://codereview.chromium.org/969833002/diff/20001/android_webview/glue/jav...
android_webview/glue/java/src/com/android/webview/chromium/ContentSettingsAdapter.java:587:
// TODO(hush):add @Override later
I advocate getting rid of all @Overrides here instead of adding more. They just
generate churn without actually helping much imo.

https://codereview.chromium.org/969833002/diff/20001/android_webview/glue/jav...
android_webview/glue/java/src/com/android/webview/chromium/ContentSettingsAdapter.java:589:
return mAwSettings.setOffscreenPreRaster(enabled);
Don't return void

[hush (inactive), 2015-03-02 19:26:28]

https://codereview.chromium.org/969833002/diff/20001/android_webview/glue/jav...
File
android_webview/glue/java/src/com/android/webview/chromium/ContentSettingsAdapter.java
(right):

https://codereview.chromium.org/969833002/diff/20001/android_webview/glue/jav...
android_webview/glue/java/src/com/android/webview/chromium/ContentSettingsAdapter.java:587:
// TODO(hush):add @Override later
On 2015/03/02 19:17:17, boliu wrote:
> I advocate getting rid of all @Overrides here instead of adding more. They
just
> generate churn without actually helping much imo.

Okay. I'm not going to add any more.

https://codereview.chromium.org/969833002/diff/20001/android_webview/glue/jav...
android_webview/glue/java/src/com/android/webview/chromium/ContentSettingsAdapter.java:589:
return mAwSettings.setOffscreenPreRaster(enabled);
On 2015/03/02 19:17:17, boliu wrote:
> Don't return void

Done.

[hush (inactive), 2015-03-02 19:27:22]

The CQ bit was checked by hush@chromium.org

[hush (inactive), 2015-03-02 19:27:23]

The patchset sent to the CQ was uploaded after l-g-t-m from boliu@chromium.org
Link to the patchset: https://codereview.chromium.org/969833002/#ps50002 (title:
" ")

[commit-bot: I haz the power, 2015-03-02 19:28:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/969833002/50002

[commit-bot: I haz the power, 2015-03-02 21:10:17]

Committed patchset #3 (id:50002)

[commit-bot: I haz the power, 2015-03-02 21:12:17]

Patchset 3 (id:??) landed as
https://crrev.com/0d149cf3d79089c25fbe69bbee6c187fe88358a2
Cr-Commit-Position: refs/heads/master@{#318758}