Unify the Windows Parental Controls Platform Caching

chrome/browser/prefs/incognito_mode_prefs.h

Index: chrome/browser/prefs/incognito_mode_prefs.h
diff --git a/chrome/browser/prefs/incognito_mode_prefs.h b/chrome/browser/prefs/incognito_mode_prefs.h
index 0837cb43e452a2f2475d3a70a5b364705a6041ae..6cb3f90c9bca00ae976fc3d36db8c86bf6211fc7 100644
--- a/chrome/browser/prefs/incognito_mode_prefs.h
+++ b/chrome/browser/prefs/incognito_mode_prefs.h
@@ -6,6 +6,7 @@
 #define CHROME_BROWSER_PREFS_INCOGNITO_MODE_PREFS_H_
 
 #include "base/basictypes.h"
+#include "base/compiler_specific.h"
 
 class PrefService;
 class Profile;
@@ -64,21 +65,12 @@ class IncognitoModePrefs {
   static bool CanOpenBrowser(Profile* profile);
 
   // Returns whether parental controls have been enabled on the platform. This
-  // method simply returns a cached value and thus the result may be stale. May
-  // be called on any thread.
-  static bool ArePlatformParentalControlsEnabledCached();
-
-#if defined(OS_WIN)
-  // Initializes the parental control settings. Must be called on UI thread and
-  // before |ArePlatformParentalControlsEnabled|.
-  static void InitializePlatformParentalControls();
-#endif // OS_WIN
+  // method evaluates and caches if the platform controls have been enabled on
+  // the first call, which must be on the UI thread when IO and blocking are
+  // allowed. Subsequent calls may be from any thread.

[gab, 2015/03/04 19:21:20]

Also mention that this must be called on the main thread *before* other threads
are created (otherwise I think the impl is not thread-safe because a static
variable isn't -- wouldn't lead to incorrect results/corruption, but could
result in computing the value many times).

base::LazyInstance can help us work around that once we want to move the
initialization to another thread.

+  static bool ArePlatformParentalControlsEnabled() WARN_UNUSED_RESULT;
 
  private:
-  // Returns whether parental controls have been enabled on the platform, which
-  // if enabled will overrule the Availability as configured in prefs.
-  static bool ArePlatformParentalControlsEnabled();
-
   DISALLOW_IMPLICIT_CONSTRUCTORS(IncognitoModePrefs);
 };