Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 969773002: Remove check of security origin of all ancestors when getUserMedia is called. (Closed)

Created:
5 years, 9 months ago by perkj_chrome
Modified:
5 years, 9 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove check of security origin of all ancestors when getUserMedia is called. This cl reverts back to the behaviour prior to https://codereview.chromium.org/795703003/. Ie, the security origin of the ancestors of a requesting iframe does not have to match in order to allow or deny a request. BUG=448378, 456628 Committed: https://crrev.com/13e3803e300d13372e4032c1f036aab15f24223f Cr-Commit-Position: refs/heads/master@{#318872}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M chrome/browser/media/media_stream_devices_controller.cc View 2 chunks +2 lines, -8 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
perkj_chrome
Can you please review.
5 years, 9 months ago (2015-03-02 16:15:53 UTC) #2
tommi (sloooow) - chröme
lgtm https://codereview.chromium.org/969773002/diff/1/chrome/browser/media/media_stream_devices_controller.cc File chrome/browser/media/media_stream_devices_controller.cc (right): https://codereview.chromium.org/969773002/diff/1/chrome/browser/media/media_stream_devices_controller.cc#newcode427 chrome/browser/media/media_stream_devices_controller.cc:427: // Store sticky permissions if |update_content_setting|. nit: I ...
5 years, 9 months ago (2015-03-03 11:43:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/969773002/1
5 years, 9 months ago (2015-03-03 13:27:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-03 14:42:37 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 14:43:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/13e3803e300d13372e4032c1f036aab15f24223f
Cr-Commit-Position: refs/heads/master@{#318872}

Powered by Google App Engine
This is Rietveld 408576698