Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 969753003: Make it possible for SkyShell embedders to register services (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
eseidel
CC:
esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make it possible for SkyShell embedders to register services We now register the sensor service from SkyDemo, which shows that embedders of SkyShell can register their own Java services. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ae9353fe0ff9b5340e1422b93052c872f71b9961

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -23 lines) Patch
M sky/apk/demo/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M sky/apk/demo/BUILD.gn View 1 chunk +9 lines, -1 line 0 comments Download
A sky/apk/demo/org/domokit/sky/demo/SkyDemoApplication.java View 1 chunk +31 lines, -0 lines 5 comments Download
M sky/shell/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/shell/org/domokit/sky/shell/JavaServiceProvider.java View 2 chunks +5 lines, -11 lines 0 comments Download
A sky/shell/org/domokit/sky/shell/ServiceFactory.java View 1 chunk +19 lines, -0 lines 0 comments Download
A sky/shell/org/domokit/sky/shell/ServiceRegistry.java View 1 chunk +31 lines, -0 lines 0 comments Download
M sky/shell/org/domokit/sky/shell/SkyApplication.java View 4 chunks +16 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
abarth-chromium
5 years, 9 months ago (2015-03-02 18:59:42 UTC) #1
eseidel
lgtm https://codereview.chromium.org/969753003/diff/1/sky/apk/demo/org/domokit/sky/demo/SkyDemoApplication.java File sky/apk/demo/org/domokit/sky/demo/SkyDemoApplication.java (right): https://codereview.chromium.org/969753003/diff/1/sky/apk/demo/org/domokit/sky/demo/SkyDemoApplication.java#newcode25 sky/apk/demo/org/domokit/sky/demo/SkyDemoApplication.java:25: ServiceRegistry.SHARED.register(SensorService.MANAGER.getName(), new ServiceFactory() { SensorService.register(self); https://codereview.chromium.org/969753003/diff/1/sky/apk/demo/org/domokit/sky/demo/SkyDemoApplication.java#newcode25 sky/apk/demo/org/domokit/sky/demo/SkyDemoApplication.java:25: ServiceRegistry.SHARED.register(SensorService.MANAGER.getName(), ...
5 years, 9 months ago (2015-03-02 21:06:18 UTC) #2
abarth-chromium
https://codereview.chromium.org/969753003/diff/1/sky/apk/demo/org/domokit/sky/demo/SkyDemoApplication.java File sky/apk/demo/org/domokit/sky/demo/SkyDemoApplication.java (right): https://codereview.chromium.org/969753003/diff/1/sky/apk/demo/org/domokit/sky/demo/SkyDemoApplication.java#newcode26 sky/apk/demo/org/domokit/sky/demo/SkyDemoApplication.java:26: public void connectToService(Context context, Core core, MessagePipeHandle pipe) { ...
5 years, 9 months ago (2015-03-02 21:12:15 UTC) #3
abarth-chromium
5 years, 9 months ago (2015-03-02 21:34:00 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
ae9353fe0ff9b5340e1422b93052c872f71b9961 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698