Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 969733003: Prefill with correct contextual load ICs in fullcodegen. (Closed)

Created:
5 years, 9 months ago by Toon Verwaest
Modified:
5 years, 9 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Compute correct contextual load ICs in fullcodegen. BUG= R=dcarney@chromium.org Committed: https://crrev.com/7ee31a2348c67ee09664519818c8feb61c82fedf Cr-Commit-Position: refs/heads/master@{#26941}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : Handle weird global-object stats #

Patch Set 6 : Don't prefill if we'll serialize the code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -4 lines) Patch
M src/arm/full-codegen-arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/code-factory.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M src/code-factory.cc View 1 2 3 4 5 1 chunk +9 lines, -0 lines 0 comments Download
M src/full-codegen.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/full-codegen.cc View 1 2 3 4 5 1 chunk +8 lines, -0 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ic.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M src/ic/ic.cc View 1 2 3 4 5 1 chunk +32 lines, -0 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Toon Verwaest
PTAL
5 years, 9 months ago (2015-03-02 13:12:09 UTC) #2
dcarney
lgtm
5 years, 9 months ago (2015-03-02 13:15:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/969733003/100001
5 years, 9 months ago (2015-03-02 13:24:24 UTC) #5
Toon Verwaest
Committed patchset #6 (id:100001) manually as 7ee31a2348c67ee09664519818c8feb61c82fedf (presubmit successful).
5 years, 9 months ago (2015-03-02 13:37:05 UTC) #6
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/7ee31a2348c67ee09664519818c8feb61c82fedf Cr-Commit-Position: refs/heads/master@{#26941}
5 years, 9 months ago (2015-03-02 13:37:09 UTC) #7
Toon Verwaest
5 years, 9 months ago (2015-03-06 07:39:37 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/983053002/ by verwaest@chromium.org.

The reason for reverting is: Eager compilation causes overhead, and doesn't work
with type feedback vector based inline caching. We'll look into a different,
lazy, approach for tfv..

Powered by Google App Engine
This is Rietveld 408576698