Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 969683003: Remove unnecessary variable, the creation of which can cause a crash. (Closed)

Created:
5 years, 9 months ago by Robert Sesek
Modified:
5 years, 9 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary variable, the creation of which can cause a crash. The NSFont object could be nil, which would have a NULL font name, which when converted to a std::string would cause a crash. The font name is already in the FontDescriptor, so it's entirely unnecessary. BUG=452651 R=avi@chromium.org Committed: https://crrev.com/b92cea6dc0d441a54574b1e17c1b82e265fd4463 Cr-Commit-Position: refs/heads/master@{#318911}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M content/common/mac/font_loader.mm View 3 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Robert Sesek
5 years, 9 months ago (2015-03-03 17:43:29 UTC) #1
Avi (use Gerrit)
Oh. LGTM
5 years, 9 months ago (2015-03-03 17:53:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/969683003/1
5 years, 9 months ago (2015-03-03 17:59:06 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-03 18:38:33 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 18:40:34 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b92cea6dc0d441a54574b1e17c1b82e265fd4463
Cr-Commit-Position: refs/heads/master@{#318911}

Powered by Google App Engine
This is Rietveld 408576698