Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 969683002: Revert of ES6: Make function name configurable (Closed)

Created:
5 years, 9 months ago by arv (Not doing code reviews)
Modified:
5 years, 9 months ago
CC:
v8-dev, yurys, kozy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of ES6: Make function name configurable (patchset #10 id:220001 of https://codereview.chromium.org/960343002/) Reason for revert: Breaks Chrome browser test that checks Object.name [16509:16509:0228/030150:INFO:CONSOLE(43)] "Uncaught Error: Clobbered Object.name getter", source: http://www.chromium.org:33611/assertions.js (43) http://build.chromium.org/p/client.v8/builders/Linux%20Tests%20%28dbg%29%281%29/builds/2328/steps/browser_tests/logs/stdio Original issue's description: > ES6: Make function name configurable > > This is partially based on r21609 but that CL was incomplete. > > Function name is still non writable so one has to use defineProperty > to change the actual value. > > BUG=v8:3333 > LOG=N > R=adamk, mstarzinger@chromium.org > > Committed: https://crrev.com/f7790f7670c8d859455a98fcb90ff1b66af1eca7 > Cr-Commit-Position: refs/heads/master@{#26924} TBR=adamk@chromium.org,mstarzinger@chromium.org,verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3333 Committed: https://crrev.com/c791d8411225aa95518c880defd9a5b1ea243afc Cr-Commit-Position: refs/heads/master@{#26933}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -199 lines) Patch
M src/accessors.cc View 1 chunk +2 lines, -34 lines 0 comments Download
M src/bootstrapper.cc View 3 chunks +15 lines, -19 lines 0 comments Download
D test/mjsunit/es6/function-name-configurable.js View 1 chunk +0 lines, -115 lines 0 comments Download
M test/mjsunit/es7/object-observe.js View 2 chunks +1 line, -27 lines 0 comments Download
M test/mjsunit/regress/regress-1530.js View 1 chunk +2 lines, -3 lines 0 comments Download
M test/mjsunit/regress/regress-270142.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
arv (Not doing code reviews)
Created Revert of ES6: Make function name configurable
5 years, 9 months ago (2015-03-02 00:18:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/969683002/1
5 years, 9 months ago (2015-03-02 00:18:43 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-02 00:18:58 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 00:19:12 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c791d8411225aa95518c880defd9a5b1ea243afc
Cr-Commit-Position: refs/heads/master@{#26933}

Powered by Google App Engine
This is Rietveld 408576698