build/standalone.gypi - Issue 969653004: When using ninja and clang, make sure diagnostics are colored.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/standalone.gypi

Issue 969653004: When using ninja and clang, make sure diagnostics are colored. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/standalone.gypi

diff --git a/build/standalone.gypi b/build/standalone.gypi

index b74e80f08b1b6cadfb09f395fa0c02fbe305e4c5..e09952b1fff8be92bc6530506ba06675745f0e89 100644

--- a/build/standalone.gypi

+++ b/build/standalone.gypi

@@ -529,6 +529,13 @@

], # target_conditions

}, # target_defaults

}], # OS=="mac"

+ ['clang==1 and "<(GENERATOR)"=="ninja"', {

+ # See http://crbug.com/110262

+ 'target_defaults': {

+ 'cflags': [ '-fcolor-diagnostics' ],

+ 'xcode_settings': { 'OTHER_CFLAGS': [ '-fcolor-diagnostics' ] },

+ },

+ }],

['clang==1 and ((OS!="mac" and OS!="ios") or clang_xcode==0) '

'and OS!="win" and "<(GENERATOR)"=="make"', {

'make_global_settings': [

« no previous file with comments | « no previous file | no next file » | no next file with comments »