Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 969643002: Sync the MessageChannel and MessagePort interfaces with the spec (Closed)

Created:
5 years, 9 months ago by philipj_slow
Modified:
5 years, 9 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-dom_chromium.org, arv+blink, vivekg_samsung, sof, eae+blinkwatch, vivekg, dglazkov+blink, Inactive, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Sync the MessageChannel and MessagePort interfaces with the spec This exposes the MessagePort interface to workers. The MessageChannel constructor was exposed to workers in spec and implementation in 2009: https://html5.org/r/3325 https://trac.webkit.org/changeset/45381 The MessagePort interface wasn't made exposed in the spec until 2014: https://html5.org/r/8425 BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191172

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -3 lines) Patch
M LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/dom/MessageChannel.idl View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/dom/MessagePort.idl View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
philipj_slow
Philip, can you take a look at this trivial but Web-exposed change?
5 years, 9 months ago (2015-03-01 15:10:34 UTC) #2
pdr.
On 2015/03/01 at 15:10:34, philipj wrote: > Philip, can you take a look at this ...
5 years, 9 months ago (2015-03-02 21:15:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/969643002/1
5 years, 9 months ago (2015-03-03 03:37:15 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 06:31:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=191172

Powered by Google App Engine
This is Rietveld 408576698