Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 969603002: gpu: Port gles2_implementation_no_check target to GN. (Closed)

Created:
5 years, 9 months ago by tfarina
Modified:
5 years, 9 months ago
Reviewers:
Dirk Pranke, jbauman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Port gles2_implementation_no_check target to GN. It is necessary because gles2_conform_supports depends on it and will port it later. Tested on Linux with the following command lines: $ gn gen out-gn $ ninja -C out-gn gles2_implementation_no_check BUG=None TEST=see above R=jbauman@chromium.org,dpranke@chromium.org CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Committed: https://crrev.com/df41605a0de6646b7288a10408f6ea768c312cd8 Cr-Commit-Position: refs/heads/master@{#318869}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M gpu/command_buffer/client/BUILD.gn View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
tfarina
5 years, 9 months ago (2015-03-01 02:23:27 UTC) #1
Dirk Pranke
LGTM. Make sure you specify CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg in the CL description so that the CQ picks ...
5 years, 9 months ago (2015-03-01 20:29:28 UTC) #2
tfarina
jbauman, I need your approval for gpu/command_buffer.
5 years, 9 months ago (2015-03-02 23:36:25 UTC) #3
jbauman
lgtm
5 years, 9 months ago (2015-03-03 00:01:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/969603002/1
5 years, 9 months ago (2015-03-03 12:48:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-03 14:11:20 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-03 14:12:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df41605a0de6646b7288a10408f6ea768c312cd8
Cr-Commit-Position: refs/heads/master@{#318869}

Powered by Google App Engine
This is Rietveld 408576698