DevTools: response writers need to post to the UI while sending into streams.

content/shell/browser/shell_devtools_frontend.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/shell/browser/shell_devtools_frontend.h"
 
 #include "base/command_line.h"
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
+#include "base/lazy_instance.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
+#include "content/public/browser/browser_thread.h"
 #include "content/public/browser/devtools_http_handler.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/content_client.h"
 #include "content/shell/browser/shell.h"
 #include "content/shell/browser/shell_browser_context.h"
 #include "content/shell/browser/shell_browser_main_parts.h"
 #include "content/shell/browser/shell_content_browser_client.h"
 #include "content/shell/browser/shell_devtools_manager_delegate.h"
 #include "content/shell/browser/webkit_test_controller.h"
 #include "content/shell/common/shell_switches.h"
 #include "net/base/io_buffer.h"
 #include "net/base/net_errors.h"
 #include "net/http/http_response_headers.h"
 #include "net/url_request/url_fetcher.h"
 #include "net/url_request/url_fetcher_response_writer.h"
 
 namespace content {
 
 namespace {
 
+using StreamOwners = std::map<int, Shell*>;
+base::LazyInstance<StreamOwners>::Leaky g_stream_owners =
+    LAZY_INSTANCE_INITIALIZER;
 
 // ResponseWriter -------------------------------------------------------------
 
 class ResponseWriter : public net::URLFetcherResponseWriter {
  public:
-  ResponseWriter(Shell* shell, int stream_id);
+  explicit ResponseWriter(int stream_id);
   ~ResponseWriter() override;
 
   // URLFetcherResponseWriter overrides:
   int Initialize(const net::CompletionCallback& callback) override;
   int Write(net::IOBuffer* buffer,
             int num_bytes,
             const net::CompletionCallback& callback) override;
   int Finish(const net::CompletionCallback& callback) override;
 
  private:
-  Shell* shell_;
   int stream_id_;
 
   DISALLOW_COPY_AND_ASSIGN(ResponseWriter);
 };
 
-ResponseWriter::ResponseWriter(Shell* shell,
-                               int stream_id)
-    : shell_(shell),
-      stream_id_(stream_id) {
+ResponseWriter::ResponseWriter(int stream_id)
+    : stream_id_(stream_id) {
 }
 
 ResponseWriter::~ResponseWriter() {
 }
 
 int ResponseWriter::Initialize(const net::CompletionCallback& callback) {
   return net::OK;
 }
 
+static void RespondOnUI(int stream_id, const std::string& code) {
+  auto it = g_stream_owners.Get().find(stream_id);
+  if (it != g_stream_owners.Get().end()) {
+    it->second->web_contents()->GetMainFrame()->ExecuteJavaScript(
+      base::UTF8ToUTF16(code));
+  }
+}
+
 int ResponseWriter::Write(net::IOBuffer* buffer,
                           int num_bytes,
                           const net::CompletionCallback& callback) {
   base::StringValue chunk(std::string(buffer->data(), num_bytes));
   std::string encoded;
   base::JSONWriter::Write(&chunk, &encoded);
-
   std::string code = base::StringPrintf(
       "DevToolsAPI.streamWrite(%d, %s)", stream_id_, encoded.c_str());
-  shell_->web_contents()->GetMainFrame()->ExecuteJavaScript(
-      base::UTF8ToUTF16(code));
 
+  content::BrowserThread::PostTask(
+      content::BrowserThread::UI, FROM_HERE,
+      base::Bind(&RespondOnUI, stream_id_, code));
   return num_bytes;
 }
 
 int ResponseWriter::Finish(const net::CompletionCallback& callback) {
   std::string code = base::StringPrintf(
       "DevToolsAPI.streamFinish(%d)", stream_id_);
-  shell_->web_contents()->GetMainFrame()->ExecuteJavaScript(
-      base::UTF8ToUTF16(code));
+  content::BrowserThread::PostTask(
+      content::BrowserThread::UI, FROM_HERE,
+      base::Bind(&RespondOnUI, stream_id_, code));
   return net::OK;
 }
 
 }  // namespace
 
 // This constant should be in sync with
 // the constant at devtools_ui_bindings.cc.
 const size_t kMaxMessageChunkSize = IPC::Channel::kMaximumMessageSize / 4;
 
 // static
@@ skipping 44 matching lines @@
 ShellDevToolsFrontend::ShellDevToolsFrontend(Shell* frontend_shell,
                                              DevToolsAgentHost* agent_host)
     : WebContentsObserver(frontend_shell->web_contents()),
       frontend_shell_(frontend_shell),
       agent_host_(agent_host) {
 }
 
 ShellDevToolsFrontend::~ShellDevToolsFrontend() {
   for (const auto& pair : pending_requests_)
     delete pair.first;
+
+  for (auto it = g_stream_owners.Get().begin();
+       it != g_stream_owners.Get().end(); ) {
+    if (it->second == frontend_shell())
+      g_stream_owners.Get().erase(it);
+    else
+      ++it;
+  }
 }
 
 void ShellDevToolsFrontend::RenderViewCreated(
     RenderViewHost* render_view_host) {
   if (!frontend_host_) {
     frontend_host_.reset(
         DevToolsFrontendHost::Create(web_contents()->GetMainFrame(), this));
   }
 }
 
@@ skipping 46 matching lines @@
     }
     GURL gurl(url);
     if (!gurl.is_valid()) {
       std::string code = base::StringPrintf(
           "DevToolsAPI.embedderMessageAck(%d, { statusCode: 404 });", id);
       web_contents()->GetMainFrame()->ExecuteJavaScript(
           base::UTF8ToUTF16(code));
       return;
     }
 
+    g_stream_owners.Get()[stream_id] = frontend_shell();
+
     net::URLFetcher* fetcher =
         net::URLFetcher::Create(gurl, net::URLFetcher::GET, this);
-    pending_requests_[fetcher] = id;
+    pending_requests_[fetcher] = std::make_pair(id, stream_id);
     fetcher->SetRequestContext(web_contents()->GetBrowserContext()->
         GetRequestContext());
     fetcher->SetExtraRequestHeaders(headers);
     fetcher->SaveResponseWithWriter(scoped_ptr<net::URLFetcherResponseWriter>(
-        new ResponseWriter(frontend_shell(), stream_id)));
+        new ResponseWriter(stream_id)));
     fetcher->Start();
     return;
   } else {
     return;
   }
 
   if (id) {
     std::string code = "DevToolsAPI.embedderMessageAck(" +
         base::IntToString(id) + ",\"\");";
     base::string16 javascript = base::UTF8ToUTF16(code);
@@ skipping 43 matching lines @@
 
   void* iterator = NULL;
   std::string name;
   std::string value;
   while (rh && rh->EnumerateHeaderLines(&iterator, &name, &value))
     headers->SetString(name, value);
 
   std::string json;
   base::JSONWriter::Write(&response, &json);
 
+  int request_id = it->second.first;
+  int stream_id = it->second.second;
   std::string message = base::StringPrintf(
       "DevToolsAPI.embedderMessageAck(%d, %s)",
-      it->second,
+      request_id,
       json.c_str());
   web_contents()->GetMainFrame()->
       ExecuteJavaScript(base::UTF8ToUTF16(message));
 
+  g_stream_owners.Get().erase(stream_id);
   pending_requests_.erase(it);
   delete source;
 }
 
 void ShellDevToolsFrontend::AttachTo(WebContents* inspected_contents) {
   DisconnectFromTarget();
   agent_host_ = DevToolsAgentHost::GetOrCreateFor(inspected_contents);
 }
 
 void ShellDevToolsFrontend::AgentHostClosed(
     DevToolsAgentHost* agent_host, bool replaced) {
   frontend_shell_->Close();
 }
 
 }  // namespace content