DevTools: response writers need to post to the UI while sending into streams.

DevTools: response writers need to post to the UI while sending into streams.

NOTRY=true
R=dgozman
BUG=

Committed: https://crrev.com/1e8f0d0d11c64852776b04ed32beb4f38611ba00
Cr-Commit-Position: refs/heads/master@{#318617}

[dgozman, 2015-02-28 16:06:13]

Why don't just have WeakPtr<DevToolsUIBindings> stored in response writer?

https://codereview.chromium.org/969573002/diff/1/chrome/browser/devtools/devt...
File chrome/browser/devtools/devtools_ui_bindings.cc (right):

https://codereview.chromium.org/969573002/diff/1/chrome/browser/devtools/devt...
chrome/browser/devtools/devtools_ui_bindings.cc:612:
g_stream_owners.Get()[stream_id] = this;
This will make streams from different DevTools clash.

[pfeldman, 2015-02-28 17:47:31]

PTAL

[dgozman, 2015-02-28 18:12:05]

lgtm

https://codereview.chromium.org/969573002/diff/20001/content/shell/browser/sh...
File content/shell/browser/shell_devtools_frontend.cc (right):

https://codereview.chromium.org/969573002/diff/20001/content/shell/browser/sh...
content/shell/browser/shell_devtools_frontend.cc:206:
web_contents()->GetMainFrame()->ExecuteJavaScript(
Use CallClientFunction.

[pfeldman, 2015-02-28 18:38:13]

https://codereview.chromium.org/969573002/diff/20001/content/shell/browser/sh...
File content/shell/browser/shell_devtools_frontend.cc (right):

https://codereview.chromium.org/969573002/diff/20001/content/shell/browser/sh...
content/shell/browser/shell_devtools_frontend.cc:206:
web_contents()->GetMainFrame()->ExecuteJavaScript(
I'd need to wrap true into fundamental value, which is going to bloat it.

[pfeldman, 2015-02-28 18:38:18]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2015-02-28 18:39:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/969573002/20001

[commit-bot: I haz the power, 2015-02-28 18:43:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-28 18:43:31]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[pfeldman, 2015-02-28 19:50:38]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2015-02-28 19:50:39]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/969573002/#ps40001 (title:
"same with no streamfinish")

[commit-bot: I haz the power, 2015-02-28 19:51:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/969573002/40001

[commit-bot: I haz the power, 2015-02-28 19:56:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-28 19:56:10]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[pfeldman, 2015-03-01 07:13:55]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2015-03-01 07:14:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/969573002/40001

[commit-bot: I haz the power, 2015-03-01 07:15:03]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-01 07:15:35]

Patchset 3 (id:??) landed as
https://crrev.com/1e8f0d0d11c64852776b04ed32beb4f38611ba00
Cr-Commit-Position: refs/heads/master@{#318617}