Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 969563002: Revert of Revert of Update V8 to version 4.3.10. (Closed)

Created:
5 years, 9 months ago by Michael Achenbach
Modified:
5 years, 9 months ago
Reviewers:
v8-autoroll, qyearsley
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Update V8 to version 4.3.10. (patchset #1 id:1 of https://codereview.chromium.org/961143003/) Reason for revert: This revert also didn't help. Relanding. Maybe something happened on these bots? The output of one test suggests to reinstall the build deps: http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29/builds/10450/steps/gfx_unittests/logs/PlatformFontLinuxTest.DefaultFont It's of course odd that this problem exists on different bots... Original issue's description: > Revert of Update V8 to version 4.3.10. (patchset #1 id:1 of https://codereview.chromium.org/965873003/) > > Reason for revert: > Speculative revert to see whether this affects some failing tests on linux: > > http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%281%29%2832%29 > > The two other Chromium commits in the narrowed-down range were reverted but that didn't help. > > Original issue's description: > > Update V8 to version 4.3.10. > > > > Summary of changes available at: > > https://chromium.googlesource.com/v8/v8/+log/27a38796..627ffe9a > > > > Please follow these instructions for assigning/CC'ing issues: > > https://code.google.com/p/v8-wiki/wiki/TriagingIssues > > > > TBR=machenbach@chromium.org > > > > Committed: https://crrev.com/a4c7ab8af2530c04fb32939585d3b021aa7d9363 > > Cr-Commit-Position: refs/heads/master@{#318556} > > TBR=machenbach@chromium.org,v8-autoroll@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/816e8760358a24ee2ddf5c748aa310caf4eab730 > Cr-Commit-Position: refs/heads/master@{#318603} TBR=v8-autoroll@chromium.org,qyearsley@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/36946bcce25da9c26cf955347354b766e8ebbf04 Cr-Commit-Position: refs/heads/master@{#318607}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Revert of Update V8 to version 4.3.10.
5 years, 9 months ago (2015-02-28 14:23:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/969563002/1
5 years, 9 months ago (2015-02-28 14:24:12 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-28 14:24:27 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-02-28 14:25:19 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/36946bcce25da9c26cf955347354b766e8ebbf04
Cr-Commit-Position: refs/heads/master@{#318607}

Powered by Google App Engine
This is Rietveld 408576698