Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 969553002: Fix crash caused by DCHECK global pointer for --single-process model

Created:
5 years, 9 months ago by jinlong.zhai
Modified:
5 years, 9 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash caused by DCHECK global pointer for --single-process model DCHECK for these three global pointers is not suitable for --single-process model, since they are created when RenderThread created and all RenderThreads under --single-process model are created in the same process (Browser Process). In this patch we will remove these three DCHECK. BUG=462848

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/media/aec_dump_message_filter.cc View 1 chunk +0 lines, -1 line 1 comment Download
M content/renderer/media/audio_input_message_filter.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/audio_message_filter.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
jinlong.zhai
hi, These crash happens when running Debug/chrome. Please take a look at. thanks, Jinlong
5 years, 9 months ago (2015-02-28 10:24:51 UTC) #2
jrummell
+tommi@, who looks like the person that added these DCHECKs and may understand the code ...
5 years, 9 months ago (2015-03-02 23:54:14 UTC) #4
jinlong.zhai
5 years, 9 months ago (2015-03-06 07:19:53 UTC) #5
On 2015/03/02 23:54:14, jrummell wrote:
> +tommi@, who looks like the person that added these DCHECKs and may understand
> the code better.
> 
>
https://codereview.chromium.org/969553002/diff/1/content/renderer/media/aec_d...
> File content/renderer/media/aec_dump_message_filter.cc (right):
> 
>
https://codereview.chromium.org/969553002/diff/1/content/renderer/media/aec_d...
> content/renderer/media/aec_dump_message_filter.cc:32: DCHECK_EQ(g_filter,
this);
> If the DCHECK in the constructor needs to be removed, why aren't these? I
would
> assume that if there is 2 creations, then one of the these would fail.

Fix in patch is not true.
I'm consider another proper way to fix it.

Powered by Google App Engine
This is Rietveld 408576698