Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(652)

Issue 969533004: [turbofan] Implement throwing exceptions into TurboFan code. (Closed)

Created:
5 years, 9 months ago by Michael Starzinger
Modified:
5 years, 9 months ago
Reviewers:
dcarney, Jarin, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Implement throwing exceptions into TurboFan code. This extends the stack unwinding logic to respect optimized frames and perform a lookup in the handler table to find handlers. It also contains fixes to the API call stubs to allow a stack walk while promoting scheduled exceptions. R=jarin@chromium.org TEST=cctest/test-run-jsexceptions Committed: https://crrev.com/1382879f29bd71c36aeda2421e867c4cdd232a0d Cr-Commit-Position: refs/heads/master@{#27016}

Patch Set 1 #

Patch Set 2 : Fix comment. #

Patch Set 3 : Architecture ports. #

Patch Set 4 : Remove debug output. #

Patch Set 5 : Fix Win64 build. #

Patch Set 6 : Fix code lookup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -97 lines) Patch
M src/arm/code-stubs-arm.cc View 1 2 3 chunks +11 lines, -15 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 2 5 chunks +10 lines, -14 lines 0 comments Download
M src/compiler/ast-graph-builder.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 3 chunks +10 lines, -12 lines 0 comments Download
M src/frames.h View 3 chunks +3 lines, -4 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 5 chunks +12 lines, -15 lines 0 comments Download
M src/isolate.cc View 1 2 3 4 5 1 chunk +83 lines, -18 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 4 chunks +14 lines, -17 lines 0 comments Download
M test/cctest/compiler/test-run-jsexceptions.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Michael Starzinger
Dan: PTAL at the CallApiStub before I do ports. Thanks! Jaro: PTAL at everything. Thanks ...
5 years, 9 months ago (2015-03-04 16:42:31 UTC) #2
dcarney
lgtm
5 years, 9 months ago (2015-03-04 18:40:24 UTC) #3
Jarin
lgtm. very cool.
5 years, 9 months ago (2015-03-05 07:30:54 UTC) #4
Michael Starzinger
Ports done. Yang: FYI about isolate.cc changes.
5 years, 9 months ago (2015-03-05 10:15:52 UTC) #6
Yang
Changes in isolate.cc lgtm.
5 years, 9 months ago (2015-03-05 10:39:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/969533004/100001
5 years, 9 months ago (2015-03-05 12:57:07 UTC) #10
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 9 months ago (2015-03-05 13:02:39 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 13:02:59 UTC) #12
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/1382879f29bd71c36aeda2421e867c4cdd232a0d
Cr-Commit-Position: refs/heads/master@{#27016}

Powered by Google App Engine
This is Rietveld 408576698