PDF: Handle hit tests for form controls and links consistently.

pdf/pdfium/pdfium_page.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "pdf/pdfium/pdfium_page.h"
 
 #include <math.h>
 
 #include "base/logging.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 240 matching lines @@
   base::DictionaryValue* node = new base::DictionaryValue();
   node->SetString(kTextNodeType, kTextNodeTypeURL);
   node->SetString(kTextNodeText, text);
   node->SetString(kTextNodeURL, url);
   return node;
 }
 
 PDFiumPage::Area PDFiumPage::GetCharIndex(const pp::Point& point,
                                           int rotation,
                                           int* char_index,
+                                          int* form_type,
                                           LinkTarget* target) {
   if (!available_)
     return NONSELECTABLE_AREA;
   pp::Point point2 = point - rect_.point();
   double new_x, new_y;
   FPDF_DeviceToPage(GetPage(), 0, 0, rect_.width(), rect_.height(),
         rotation, point2.x(), point2.y(), &new_x, &new_y);
 
   int rv = FPDFText_GetCharIndexAtPos(
       GetTextPage(), new_x, new_y, kTolerance, kTolerance);
   *char_index = rv;
 
+  int control =
+      FPDPage_HasFormFieldAtPoint(engine_->form(), GetPage(), new_x, new_y);

[Lei Zhang, 2015/02/28 01:16:14]

FPDPage_HasFormFieldAtPoint() and FPDFLink_GetLinkAtPoint() can both return
valid data if there exists one object of each type and they overlap. We'll need
to fix that corner case in PDFium separately.

I'm just putting FPDPage_HasFormFieldAtPoint() here first because it happens to
fix the bug, and eventually this will all work out.

+  if (control > FPDF_FORMFIELD_UNKNOWN) {
+    *form_type = control;
+    return PDFiumPage::NONSELECTABLE_AREA;
+  }
+
   FPDF_LINK link = FPDFLink_GetLinkAtPoint(GetPage(), new_x, new_y);
   if (link) {
     // We don't handle all possible link types of the PDF. For example,
     // launch actions, cross-document links, etc.
     // In that case, GetLinkTarget() will return NONSELECTABLE_AREA
     // and we should proceed with area detection.
     PDFiumPage::Area area = GetLinkTarget(link, target);
     if (area != PDFiumPage::NONSELECTABLE_AREA)
       return area;
   }
@@ skipping 217 matching lines @@
   page_->loading_count_--;
 }
 
 PDFiumPage::Link::Link() {
 }
 
 PDFiumPage::Link::~Link() {
 }
 
 }  // namespace chrome_pdf