Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 969513002: PDF: Handle hit tests for form controls and links consistently. (Closed)

Created:
5 years, 9 months ago by Lei Zhang
Modified:
5 years, 9 months ago
Reviewers:
gene, jam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PDF: Handle hit tests for form controls and links consistently. BUG=434064 Committed: https://crrev.com/0ad537cdce686af79f130f4a9cb30d40572e7aef Cr-Commit-Position: refs/heads/master@{#318748}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -56 lines) Patch
M pdf/pdfium/pdfium_engine.h View 1 chunk +2 lines, -0 lines 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 9 chunks +54 lines, -55 lines 0 comments Download
M pdf/pdfium/pdfium_page.h View 1 chunk +1 line, -1 line 0 comments Download
M pdf/pdfium/pdfium_page.cc View 2 chunks +8 lines, -0 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
Lei Zhang
https://codereview.chromium.org/969513002/diff/1/pdf/pdfium/pdfium_page.cc File pdf/pdfium/pdfium_page.cc (right): https://codereview.chromium.org/969513002/diff/1/pdf/pdfium/pdfium_page.cc#newcode275 pdf/pdfium/pdfium_page.cc:275: FPDPage_HasFormFieldAtPoint(engine_->form(), GetPage(), new_x, new_y); FPDPage_HasFormFieldAtPoint() and FPDFLink_GetLinkAtPoint() can both ...
5 years, 9 months ago (2015-02-28 01:16:14 UTC) #2
jam
lgtm
5 years, 9 months ago (2015-03-02 16:24:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/969513002/1
5 years, 9 months ago (2015-03-02 20:04:11 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-02 21:03:27 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 21:04:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ad537cdce686af79f130f4a9cb30d40572e7aef
Cr-Commit-Position: refs/heads/master@{#318748}

Powered by Google App Engine
This is Rietveld 408576698