Issue 969493002: Add support for scroll and fling gestures to SkyShell.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 969493002: Add support for scroll and fling gestures to SkyShell. (Closed)

Created:
5 years, 9 months ago by eseidel

Modified:
5 years, 9 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add support for scroll and fling gestures to SkyShell. This is not complete gesture support by far, but it's a start. MojoShell and Chrome use a C++ GestureDetector, this code attempts to use the Android (Java) GestureDetector instead. We probably should not be sending gesturetap until we've decided it's not a scroll, etc, but this implementation does not go that far. I had to fix a bug whereby we were assuming the InputEvent.time_stamp was in TimeDelta's internal format, which was wrong. When we get time_stamp from Android its in ms since boot. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/03b38037abdf852c8421fdbc57d022cae8f924ea

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+217 lines, -10 lines)			Patch
M	sky/framework/sky-scrollable.sky	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
M	sky/services/viewport/input_event.mojom	View		2 chunks	+15 lines, -0 lines	0 comments	Download
M	sky/shell/BUILD.gn	View		1 chunk	+2 lines, -1 line	0 comments	Download
A	sky/shell/org/domokit/sky/shell/GestureProvider.java	View		1 chunk	+126 lines, -0 lines	0 comments	Download
M	sky/shell/org/domokit/sky/shell/PlatformView.java	View		4 chunks	+14 lines, -1 line	0 comments	Download
M	sky/shell/ui/input_event_converter.cc	View		2 chunks	+57 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

eseidel

5 years, 9 months ago (2015-02-28 00:46:24 UTC) #3

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
03b38037abdf852c8421fdbc57d022cae8f924ea (presubmit successful).

Expand Messages | Collapse Messages

Issue 969493002: Add support for scroll and fling gestures to SkyShell. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Should be the same #

Patch Set 3 : Snap scrolling to logical pixels #

Patch Set 4 : updated #

Messages