[Document mode] Keep tab ID list in sync with Tab entries

[Document mode] Keep tab ID list in sync with Tab entries

It is possible to have one DocumentActivity create a Tab and add its ID to the
DocumentTabModel, but get interrupted (somehow) before the Tab Entry is added
to the DocumentTabModel.  This results in getCount() returning the correct number
of Tabs that exist but fail to have any information about the new Tab, resulting
in getTabAt() returning |null|.  We should instead keep the ID list and the Entry
list be as in sync as possible, adding the Entry directly to the DocumentTabModel
as soon as we let the DocumentTabModel know about the Tab's existence.

Add new methods to tie the addTabId and updateEntry functions together via addTab,
deprecate the old ones, and assert that we should never get into a bad state.
Deprecated methods will be culled when the downstream patch lands.

BUG=457427
Committed: https://crrev.com/7710ef5ff57f581f66dbbaad2dffe8c4a9048add
Cr-Commit-Position: refs/heads/master@{#318576}

[gone, 2015-02-27 23:56:23]

dfalcantara@chromium.org changed reviewers:
+ mariakhomenko@chromium.org, tedchoc@chromium.org

[Ted C, 2015-02-28 00:31:57]

lgtm

https://codereview.chromium.org/969443003/diff/1/chrome/android/java/src/org/...
File
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModel.java
(right):

https://codereview.chromium.org/969443003/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModel.java:168:
@Deprecated
@Deprecated makes @newt sad...do you want that?  If so, keep in.  If not, take
out.  And then turn yourself around.

[Maria, 2015-02-28 00:34:16]

lgtm

[gone, 2015-02-28 00:47:34]

https://codereview.chromium.org/969443003/diff/1/chrome/android/java/src/org/...
File
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModel.java
(right):

https://codereview.chromium.org/969443003/diff/1/chrome/android/java/src/org/...
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModel.java:168:
@Deprecated
On 2015/02/28 00:31:57, Ted C wrote:
> @Deprecated makes @newt sad...do you want that?  If so, keep in.  If not, take
> out.  And then turn yourself around.

newt@ is incapable of sadness.  His middle name shares a roots with "perky".

[gone, 2015-02-28 00:47:37]

The CQ bit was checked by dfalcantara@chromium.org

[gone, 2015-02-28 00:47:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
tedchoc@chromium.org, mariakhomenko@chromium.org
Link to the patchset: https://codereview.chromium.org/969443003/#ps20001 (title:
"Deprecated")

[commit-bot: I haz the power, 2015-02-28 00:48:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/969443003/20001

[gone, 2015-02-28 00:58:02]

The CQ bit was unchecked by dfalcantara@chromium.org

[gone, 2015-02-28 00:59:21]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2015-02-28 00:59:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/969443003/20001

[commit-bot: I haz the power, 2015-02-28 02:25:15]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-02-28 02:26:21]

Patchset 2 (id:??) landed as
https://crrev.com/7710ef5ff57f581f66dbbaad2dffe8c4a9048add
Cr-Commit-Position: refs/heads/master@{#318576}