net/quic/quic_sent_packet_manager.cc - Issue 969443002: Deprecating FLAGS_quic_attach_ack_notifiers_to_packets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_sent_packet_manager.cc

Issue 969443002: Deprecating FLAGS_quic_attach_ack_notifiers_to_packets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Remove_RevertRetransmissionTimeout_86651704

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_sent_packet_manager.cc

diff --git a/net/quic/quic_sent_packet_manager.cc b/net/quic/quic_sent_packet_manager.cc

index 0870b49947c8e09379f81e8cb1960dc6dfda7af9..9c502f4d3e318e37f97394951e0918143d2c44d7 100644

--- a/net/quic/quic_sent_packet_manager.cc

+++ b/net/quic/quic_sent_packet_manager.cc

@@ -476,11 +476,8 @@ void QuicSentPacketManager::MarkPacketRevived(

// The AckNotifierManager needs to be notified for revived packets,

// since it indicates the packet arrived from the appliction's perspective.

- if (FLAGS_quic_attach_ack_notifiers_to_packets ||

- transmission_info.retransmittable_frames) {

- ack_notifier_manager_.OnPacketAcked(newest_transmission,

- delta_largest_observed);

- }

+ ack_notifier_manager_.OnPacketAcked(newest_transmission,

+ delta_largest_observed);

unacked_packets_.RemoveRetransmittability(sequence_number);

}

« no previous file with comments | « net/quic/quic_protocol.cc ('k') | net/tools/quic/end_to_end_test.cc » ('j') | no next file with comments »