net/quic/quic_protocol.h - Issue 969443002: Deprecating FLAGS_quic_attach_ack_notifiers_to_packets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_protocol.h

Issue 969443002: Deprecating FLAGS_quic_attach_ack_notifiers_to_packets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Remove_RevertRetransmissionTimeout_86651704

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/quic_protocol.h

diff --git a/net/quic/quic_protocol.h b/net/quic/quic_protocol.h

index 2bb678bdb9a3125c1a4087f02c1df4da187b7423..b68a9940b82f153713e29f349492d0b92cc6c61a 100644

--- a/net/quic/quic_protocol.h

+++ b/net/quic/quic_protocol.h

@@ -662,11 +662,6 @@ struct NET_EXPORT_PRIVATE QuicStreamFrame {

bool fin;

QuicStreamOffset offset; // Location of this data in the stream.

IOVector data;

- // TODO(rjshade): Remove with FLAGS_quic_attach_ack_notifiers_to_packets.

- // If this is set, then when this packet is ACKed the AckNotifier will be

- // informed.

- QuicAckNotifier* notifier;

};

// TODO(ianswett): Re-evaluate the trade-offs of hash_set vs set when framing

« no previous file with comments | « net/quic/quic_packet_generator.cc ('k') | net/quic/quic_protocol.cc » ('j') | no next file with comments »